710177 - JSON doc for stringify needs fixing

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Library, defect)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

Lars noted that in JSON.as, the doc block above stringify is odd, it talks about "parsing", but stringify does not parse.  (Words like "serialize" or "marshal" would be more appropriate and probably better english than alternatives like "unparse" or "stringify")

Also, the text says: "your transformed or filtered value for each pair, rather than the default parsing, is returned in the <code>parse()</code> function output"; but by their very nature, filtered values are not part of the output.

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

(should take care of Bug 702551 first so that we don't get merge conflicts)

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

After Bug 702551 landed, I noticed this odd sentence:

  When the argument passed to the <code>space</code> parameter is not a String or a Number, it is converted to a String. This string serves as the gap in the output.  ECMA-262 requires the gap to be an empty string.

This is poor phrasing at best; ECMA-262 does not *require* gap to be an empty string.  I suspect the author meant to say something like "ECMA-262 *defaults* the gap to the empty string", or similar.

Comment 3

[Felix S. Klock II [:pnkfelix, :fklock]]

not gonna fix this at the moment.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.