Last Comment Bug 710219 - Separate debugger JS modules from plain scripts
: Separate debugger JS modules from plain scripts
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Debugger (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Panos Astithas [:past] (away until 7/21)
:
Mentors:
Depends on:
Blocks: minotaur 697762
  Show dependency treegraph
 
Reported: 2011-12-13 07:42 PST by Panos Astithas [:past] (away until 7/21)
Modified: 2012-01-04 12:15 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
WIP (10.94 KB, patch)
2011-12-13 09:32 PST, Panos Astithas [:past] (away until 7/21)
rcampbell: review+
dcamp: review+
Details | Diff | Splinter Review

Description Panos Astithas [:past] (away until 7/21) 2011-12-13 07:42:53 PST
The debugger JS files that are not modules should not be installed with the others and should be loaded with simple chrome URLs. The list includes: dbg-server.js, dbg-transport.js, dbg-browser-actors.js and dbg-script-actors.js.
Comment 1 Panos Astithas [:past] (away until 7/21) 2011-12-13 09:32:23 PST
Created attachment 581305 [details] [diff] [review]
WIP

Moved the scripts and modules under a devtools/ prefix as well. This is not working yet for some reason, but I'll figure it out eventually.
Comment 2 Panos Astithas [:past] (away until 7/21) 2011-12-14 03:35:14 PST
Comment on attachment 581305 [details] [diff] [review]
WIP

Weird, it worked fine today after clobbering the build once more. Had I known that yesterday, I wouldn't have split this out into a separate bug.

I'm asking both of you for review in the spirit of landing the debugger with at least two peer reviews.
Comment 3 Rob Campbell [:rc] (:robcee) 2011-12-16 09:01:59 PST
Comment on attachment 581305 [details] [diff] [review]
WIP

that is a whole lotta load (insert led zeppelin guitar track)
Comment 4 Panos Astithas [:past] (away until 7/21) 2012-01-04 12:15:00 PST
https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/6fdee4681f7e

Note You need to log in before you can comment on or make changes to this bug.