Separate debugger JS modules from plain scripts

RESOLVED FIXED

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The debugger JS files that are not modules should not be installed with the others and should be loaded with simple chrome URLs. The list includes: dbg-server.js, dbg-transport.js, dbg-browser-actors.js and dbg-script-actors.js.
Created attachment 581305 [details] [diff] [review]
WIP

Moved the scripts and modules under a devtools/ prefix as well. This is not working yet for some reason, but I'll figure it out eventually.
Comment on attachment 581305 [details] [diff] [review]
WIP

Weird, it worked fine today after clobbering the build once more. Had I known that yesterday, I wouldn't have split this out into a separate bug.

I'm asking both of you for review in the spirit of landing the debugger with at least two peer reviews.
Attachment #581305 - Flags: review?(rcampbell)
Attachment #581305 - Flags: review?(dcamp)
Comment on attachment 581305 [details] [diff] [review]
WIP

that is a whole lotta load (insert led zeppelin guitar track)
Attachment #581305 - Flags: review?(rcampbell) → review+

Updated

6 years ago
Attachment #581305 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/6fdee4681f7e
Blocks: 697762
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.