710225 - Label nodes produce negative lengths

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Ángel Eduardo]

Attachment: test.js

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/535.2 (KHTML, like Gecko) Chrome/15.0.874.121 Safari/535.2

Steps to reproduce:

Rhino generates negative lengths for some AST nodes when using labels in some cases, like the simple attached test.


Actual results:

The LabeledStatement that contains the while for the second function has a length of -10. If you remove the first empty function, the length is positive again, but as far as I know, also incorrect (because length for the inside While node is greater)

Comment 1

[Ángel Eduardo]

I made a fix and created a pull request here: https://github.com/mozilla/rhino/pull/26

Comment 2

[Hannes Wallnoefer]

Thanks, fixed in master and rhino_1_8 branches:

https://github.com/mozilla/rhino/commit/a518c4e1128a5dac63dc110d8ce5e7619694a015