The default bug view has changed. See this FAQ.

sign NSS libraries only when they exist

RESOLVED FIXED in Firefox -esr10

Status

()

Toolkit
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Takanori MATSUURA, Assigned: Takanori MATSUURA)

Tracking

({regression})

unspecified
mozilla11
regression
Points:
---

Firefox Tracking Flags

(firefox-esr10 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There are two cases that shlibsign is not generated in the build tree:

1. Build with using system NSS
2. Build Firefox on top of Xulrunner

So we need to sign to SOFTOKN and NSSDBM libraries only when shlibsign exists.
(Assignee)

Comment 1

5 years ago
Created attachment 581312 [details] [diff] [review]
Fix

Sign SOFTOKN and NSSDBM only when they exist. shlibsign exists if internal NSS is built.
Attachment #581312 - Flags: review?(dtownsend)
Attachment #581312 - Flags: review?(dtownsend) → review+
(Assignee)

Updated

5 years ago
Assignee: nobody → t.matsuu
Status: NEW → ASSIGNED
Keywords: checkin-needed
In my queue with a few other checkin-neededs that are being sent to try first and then onto inbound :-)
https://tbpl.mozilla.org/?tree=Try&rev=fd440327d5e4
Keywords: checkin-needed
OS: Linux → All
Hardware: x86_64 → All
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bea36280f9a
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/2bea36280f9a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
This is fixing a regression introduced by another bugfix. (sorry, not sure which one)
That bugfix was applied on releases/mozilla-esr10 and therefore the 10.0.3esr sources are not correctly building in above cases. Please apply this one to 10ESR as well.
tracking-firefox-esr10: --- → ?
Keywords: regression
Comment on attachment 581312 [details] [diff] [review]
Fix

please go ahead and land this to esr branch - see https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for details
Attachment #581312 - Flags: approval-mozilla-esr10+
status-firefox-esr10: --- → affected
tracking-firefox-esr10: ? → 11+
[Triage Comment]
untracking since this isn't part of our builds, you can land this to esr branch when you need to, if you still want it - since it is of no risk to the builds.
tracking-firefox-esr10: 11+ → ---
https://hg.mozilla.org/releases/mozilla-esr10/rev/b70216a1859d
status-firefox-esr10: affected → fixed
Duplicate of this bug: 736327
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.