Closed
Bug 710268
Opened 12 years ago
Closed 12 years ago
sign NSS libraries only when they exist
Categories
(Toolkit Graveyard :: Build Config, defect)
Toolkit Graveyard
Build Config
Tracking
(firefox-esr10 fixed)
RESOLVED
FIXED
mozilla11
Tracking | Status | |
---|---|---|
firefox-esr10 | --- | fixed |
People
(Reporter: t.matsuu, Assigned: t.matsuu)
References
Details
(Keywords: regression, Whiteboard: [qa-])
Attachments
(1 file)
1.85 KB,
patch
|
mossop
:
review+
lsblakk
:
approval-mozilla-esr10+
|
Details | Diff | Splinter Review |
There are two cases that shlibsign is not generated in the build tree: 1. Build with using system NSS 2. Build Firefox on top of Xulrunner So we need to sign to SOFTOKN and NSSDBM libraries only when shlibsign exists.
Assignee | ||
Comment 1•12 years ago
|
||
Sign SOFTOKN and NSSDBM only when they exist. shlibsign exists if internal NSS is built.
Attachment #581312 -
Flags: review?(dtownsend)
Updated•12 years ago
|
Attachment #581312 -
Flags: review?(dtownsend) → review+
Assignee | ||
Updated•12 years ago
|
Comment 2•12 years ago
|
||
In my queue with a few other checkin-neededs that are being sent to try first and then onto inbound :-) https://tbpl.mozilla.org/?tree=Try&rev=fd440327d5e4
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bea36280f9a
Target Milestone: --- → mozilla11
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2bea36280f9a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 5•12 years ago
|
||
This is fixing a regression introduced by another bugfix. (sorry, not sure which one) That bugfix was applied on releases/mozilla-esr10 and therefore the 10.0.3esr sources are not correctly building in above cases. Please apply this one to 10ESR as well.
tracking-firefox-esr10:
--- → ?
Keywords: regression
Comment 6•12 years ago
|
||
Comment on attachment 581312 [details] [diff] [review] Fix please go ahead and land this to esr branch - see https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for details
Attachment #581312 -
Flags: approval-mozilla-esr10+
Updated•12 years ago
|
status-firefox-esr10:
--- → affected
Comment 7•12 years ago
|
||
[Triage Comment] untracking since this isn't part of our builds, you can land this to esr branch when you need to, if you still want it - since it is of no risk to the builds.
tracking-firefox-esr10:
11+ → ---
Updated•5 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•