Patch for PropertiesTest.cpp

VERIFIED FIXED in M7

Status

()

Core
XPCOM
P3
normal
VERIFIED FIXED
19 years ago
19 years ago

People

(Reporter: Andreas Otte, Assigned: Suresh Duddi (gone))

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

19 years ago
After the XPCOM 2.0 landing, this are some changes to get
xpcom/tests/PropertiesTest working:


Index: PropertiesTest.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpcom/tests/PropertiesTest.cpp,v
retrieving revision 1.10
diff -r1.10 PropertiesTest.cpp
35,36d34
< #define RAPTORBASE_DLL "raptorbase.dll"
< #define XPCOM_DLL "xpcom32.dll"
40,41d37
< #define RAPTORBASE_DLL "base.shlb"
< #define XPCOM_DLL "XPCOM_DLL"
44,45d39
< #define RAPTORBASE_DLL "libraptorbase.so"
< #define XPCOM_DLL "libxpcom.so"
64a59,63
>   // XXX why do I have to do this?!
>   ret = nsComponentManager::AutoRegister(nsIComponentManager::NS_Startup,
>                                          "components");
>   if (NS_FAILED(ret)) return ret;
>
67,88c66
<   if (NS_FAILED(ret)) {
<     printf("cannot register net service\n");
<     return 1;
<   }
<   ret = nsComponentManager::RegisterComponent(kEventQueueCID, NULL,
<     NULL, XPCOM_DLL, PR_FALSE, PR_FALSE);
<   if (NS_FAILED(ret)) {
<     printf("cannot register event queue\n");
<     return 1;
<   }
<   ret = nsComponentManager::RegisterComponent(kEventQueueServiceCID, NULL,
<     NULL, XPCOM_DLL, PR_FALSE, PR_FALSE);
<   if (NS_FAILED(ret)) {
<     printf("cannot register event queue service\n");
<     return 1;
<   }
<   ret = nsComponentManager::RegisterComponent(kPersistentPropertiesCID, NULL,
<     NULL, RAPTORBASE_DLL, PR_FALSE, PR_FALSE);
<   if (NS_FAILED(ret)) {
<     printf("cannot register persistent properties\n");
<     return 1;
<   }
---
>
(Reporter)

Comment 1

19 years ago
Created attachment 271 [details] [diff] [review]
Patch-Diff for PropertiesTest.cpp
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
Target Milestone: M7
(Assignee)

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

19 years ago
h-208-12-39-138 # cvs commit -m "Patch from andreas.otte@primus-online.de Thanks
 Andreas" PropertiesTest.cpp
Checking in PropertiesTest.cpp;
/cvsroot/mozilla/xpcom/tests/PropertiesTest.cpp,v  <--  PropertiesTest.cpp
new revision: 1.11; previous revision: 1.10
done

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 3

19 years ago
code level fix, marking verified per developer input
You need to log in before you can comment on or make changes to this bug.