Closed Bug 710323 Opened 9 years ago Closed 9 years ago

about:home - clicking on addons should go to their page in AMO

Categories

(Firefox for Android Graveyard :: General, defect, P1)

ARM
Android
defect

Tracking

(firefox11 affected, firefox12 affected, firefox13 verified, blocking-fennec1.0 +, fennec11+)

VERIFIED FIXED
Firefox 13
Tracking Status
firefox11 --- affected
firefox12 --- affected
firefox13 --- verified
blocking-fennec1.0 --- +
fennec 11+ ---

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

(Whiteboard: [QA!])

Attachments

(3 files, 1 obsolete file)

Right now it doesn't do anything.
Priority: -- → P1
Hardware: All → ARM
Assignee: nobody → lucasr.at.mozilla
tracking-fennec: --- → 11+
I couldn't find anywhere in recommended addons file an addonID that I could use to go straight to the addon page in AMO. XUL fennec simply does an addon search using about:addons but I think this is not implemented yet in native UI's about:addons.

So, this patch simply does a search on AMO using the addon name. Mark, how is this expected to work?
Attachment #586997 - Flags: feedback?(mark.finkle)
Duplicate of this bug: 715262
Comment on attachment 586997 [details] [diff] [review]
Search addon on AMO when clicking on an addon in about:home

You have the right idea, but here are some other pieces to the puzzle:
* We have specialized URLs for running a search on AMO. See :http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#219
* AMO doesn't yet support native Fennec, but let's go through the motions anyway. Just use the existing prefs for your values.
* Don't put any data in Java. I don't like the amount we have there now. Instead, send a message to JS, "Addons:Show", along with the name of the add-on.
  * In JS we can use URLFormatter to get a formatted pref URL and open a new tab with the URL. Example here http://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/extensions.js#746

We could make messages for "Addon:Show" that sends a specific add-on, and "Addon:Search" which is passed a search term.
Attachment #586997 - Flags: feedback?(mark.finkle) → feedback-
Last I heard AMO now supports native Fennec. What is the status of this feature? Cutting it close to beta for testing purposes.
This will require further QA AMO/add-on integration testing.
Whiteboard: [QA+]
Attachment #586997 - Attachment is obsolete: true
Comment on attachment 599981 [details] [diff] [review]
(1/3) Don't save unused properties for recommended addons

these were used in XUL, but not in native
Attachment #599981 - Flags: review?(mark.finkle) → review+
Attachment #599982 - Flags: review?(mark.finkle) → review+
Comment on attachment 599983 [details] [diff] [review]
(3/3) Clicking on addons should go to their page in AMO

I assume homepageUrl will always be valid
Attachment #599983 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #10)
> Comment on attachment 599983 [details] [diff] [review]
> (3/3) Clicking on addons should go to their page in AMO
> 
> I assume homepageUrl will always be valid

If it's not, this is a bug somewhere else and we'll have to fix it.
Flags: in-litmus?(fennec)
Depends on: 730273
blocking-fennec1.0: --- → +
Verified fixed on:

Firefox 13.0a1 (2012-02-28)
20120228031102
http://hg.mozilla.org/mozilla-central/rev/7ce4d9b55863

--
Device: Samsung Galaxy S2
OS: Android 2.3.4
Status: RESOLVED → VERIFIED
Whiteboard: [QA+] → [QA!]
Test case in litmus under BFT - Add-ons testing:
https://litmus.mozilla.org/show_test.cgi?id=48651
Flags: in-litmus?(fennec) → in-litmus+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.