710323 - about:home - clicking on addons should go to their page in AMO

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Lucas Rocha (:lucasr)]

Right now it doesn't do anything.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Search addon on AMO when clicking on an addon in about:home

I couldn't find anywhere in recommended addons file an addonID that I could use to go straight to the addon page in AMO. XUL fennec simply does an addon search using about:addons but I think this is not implemented yet in native UI's about:addons.

So, this patch simply does a search on AMO using the addon name. Mark, how is this expected to work?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 586997 [details] [diff] [review]
Search addon on AMO when clicking on an addon in about:home

You have the right idea, but here are some other pieces to the puzzle:
* We have specialized URLs for running a search on AMO. See :http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#219
* AMO doesn't yet support native Fennec, but let's go through the motions anyway. Just use the existing prefs for your values.
* Don't put any data in Java. I don't like the amount we have there now. Instead, send a message to JS, "Addons:Show", along with the name of the add-on.
  * In JS we can use URLFormatter to get a formatted pref URL and open a new tab with the URL. Example here http://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/extensions.js#746

We could make messages for "Addon:Show" that sends a specific add-on, and "Addon:Search" which is passed a search term.

Comment 4

[Aaron Train [:aaronmt]]

Last I heard AMO now supports native Fennec. What is the status of this feature? Cutting it close to beta for testing purposes.

Comment 5

[Aaron Train [:aaronmt]]

This will require further QA AMO/add-on integration testing.

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: (1/3) Don't save unused properties for recommended addons

Comment 7

[Lucas Rocha (:lucasr)]

Attachment: (2/3) Save homepageURL property for recommended addons

Comment 8

[Lucas Rocha (:lucasr)]

Attachment: (3/3) Clicking on addons should go to their page in AMO

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 599981 [details] [diff] [review]
(1/3) Don't save unused properties for recommended addons

these were used in XUL, but not in native

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 599983 [details] [diff] [review]
(3/3) Clicking on addons should go to their page in AMO

I assume homepageUrl will always be valid

Comment 11

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #10)
> Comment on attachment 599983 [details] [diff] [review]
> (3/3) Clicking on addons should go to their page in AMO
> 
> I assume homepageUrl will always be valid

If it's not, this is a bug somewhere else and we'll have to fix it.

Comment 12

[Lucas Rocha (:lucasr)]

Pushed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/97dbe3a1350d
http://hg.mozilla.org/integration/mozilla-inbound/rev/cb7dcc6ba424
http://hg.mozilla.org/integration/mozilla-inbound/rev/4a3aa15868b5

Comment 13

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/97dbe3a1350d
https://hg.mozilla.org/mozilla-central/rev/cb7dcc6ba424
https://hg.mozilla.org/mozilla-central/rev/4a3aa15868b5

Comment 14

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-02-28)
20120228031102
http://hg.mozilla.org/mozilla-central/rev/7ce4d9b55863

--
Device: Samsung Galaxy S2
OS: Android 2.3.4

Comment 15

[Camelia Urian]

Test case in litmus under BFT - Add-ons testing:
https://litmus.mozilla.org/show_test.cgi?id=48651