Last Comment Bug 710380 - IndexedDB could use the tool from bug 709569 for dictionaries
: IndexedDB could use the tool from bug 709569 for dictionaries
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: IndexedDB (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
Mentors:
Depends on: 709569
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-13 13:38 PST by Olli Pettay [:smaug]
Modified: 2012-03-22 11:54 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (10.46 KB, patch)
2011-12-13 13:47 PST, Olli Pettay [:smaug]
no flags Details | Diff | Splinter Review
up-to-date (10.47 KB, patch)
2011-12-26 09:03 PST, Olli Pettay [:smaug]
khuey: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] 2011-12-13 13:38:40 PST

    
Comment 1 Olli Pettay [:smaug] 2011-12-13 13:47:55 PST
Created attachment 581413 [details] [diff] [review]
patch

This passes IndexedDB tests.

I believe !JSVAL_IS_NULL(aOptions) checks are wrong in the ifs, but I decided to
not change them, so the behavior should stay the same.

I did this change to figure out whether the tool in bug 709569 works
with this case.
Comment 2 Olli Pettay [:smaug] 2011-12-26 05:28:30 PST
Comment on attachment 581413 [details] [diff] [review]
patch

This doesn't apply cleanly anymore
Comment 3 Olli Pettay [:smaug] 2011-12-26 09:03:42 PST
Created attachment 584332 [details] [diff] [review]
up-to-date
Comment 4 Olli Pettay [:smaug] 2011-12-26 09:11:58 PST
https://tbpl.mozilla.org/?tree=Try&rev=7efe88c95944
Comment 5 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-12-27 08:53:35 PST
Comment on attachment 584332 [details] [diff] [review]
up-to-date

Review of attachment 584332 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful.
Comment 6 Olli Pettay [:smaug] 2011-12-27 10:27:09 PST
https://hg.mozilla.org/mozilla-central/rev/a8be91348c31

Note You need to log in before you can comment on or make changes to this bug.