IndexedDB could use the tool from bug 709569 for dictionaries

RESOLVED FIXED

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

6 years ago
Depends on: 709569
(Assignee)

Comment 1

6 years ago
Created attachment 581413 [details] [diff] [review]
patch

This passes IndexedDB tests.

I believe !JSVAL_IS_NULL(aOptions) checks are wrong in the ifs, but I decided to
not change them, so the behavior should stay the same.

I did this change to figure out whether the tool in bug 709569 works
with this case.
Attachment #581413 - Flags: review?(jonas)
(Assignee)

Comment 2

6 years ago
Comment on attachment 581413 [details] [diff] [review]
patch

This doesn't apply cleanly anymore
Attachment #581413 - Flags: review?(jonas)
(Assignee)

Comment 3

6 years ago
Created attachment 584332 [details] [diff] [review]
up-to-date
Attachment #581413 - Attachment is obsolete: true
(Assignee)

Comment 4

6 years ago
https://tbpl.mozilla.org/?tree=Try&rev=7efe88c95944
(Assignee)

Updated

6 years ago
Attachment #584332 - Flags: review?(khuey)
Comment on attachment 584332 [details] [diff] [review]
up-to-date

Review of attachment 584332 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful.
Attachment #584332 - Flags: review?(khuey) → review+
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/a8be91348c31
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Component: DOM → DOM: IndexedDB
You need to log in before you can comment on or make changes to this bug.