Closed Bug 710380 Opened 9 years ago Closed 9 years ago

IndexedDB could use the tool from bug 709569 for dictionaries

Categories

(Core :: Storage: IndexedDB, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Depends on: 709569
Attached patch patch (obsolete) — Splinter Review
This passes IndexedDB tests.

I believe !JSVAL_IS_NULL(aOptions) checks are wrong in the ifs, but I decided to
not change them, so the behavior should stay the same.

I did this change to figure out whether the tool in bug 709569 works
with this case.
Attachment #581413 - Flags: review?(jonas)
Comment on attachment 581413 [details] [diff] [review]
patch

This doesn't apply cleanly anymore
Attachment #581413 - Flags: review?(jonas)
Attached patch up-to-dateSplinter Review
Attachment #581413 - Attachment is obsolete: true
Attachment #584332 - Flags: review?(khuey)
Comment on attachment 584332 [details] [diff] [review]
up-to-date

Review of attachment 584332 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful.
Attachment #584332 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/a8be91348c31
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: DOM → DOM: IndexedDB
You need to log in before you can comment on or make changes to this bug.