710506 - Parsing let bug

Status: RESOLVED FIXED

(Other Applications Graveyard :: Narcissus, defect)

Description

[Dimitris Vardoulakis]

Narcissus throws a syntax error "missing ; before statement" when trying to parse the following snippet:

let(x=1){}y=5;

It wants a semicolon after the right curly. But it can parse this:

if(x=1){}y=5;

In jsparse, function MagicalSemicolon, line 875 is where the first snippet fails but the second is fine.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Fix v1

In the case of |if|, we return from Statement early if the |if| block was successfully parsed, thus never calling |MagicalSemicolon|. The |let| block case was breaking out of the giant switch and then calling |MagicalSemicolon|.

This patch should fix that.

Comment 2

[Dimitris Vardoulakis]

Thanks Shu. Go ahead and push that to the master branch on Github. Also, the github repo should allow issues to be filed, and then people can submit bug reports there directly.

Comment 3

[Shu-yu Guo [:shu]]

I don't have permanent internet until at least Saturday, and these cafes I'm mooching internet off of tend to block everything except HTTP. Could you just push it for me? (or wait until Saturday)

Comment 4

[Dimitris Vardoulakis]

I'm not an admin so I can't. Maybe Dave can do it, o/w Sat is fine.

Comment 5

[Shu-yu Guo [:shu]]

https://github.com/mozilla/narcissus/commit/4ae5aff8b3c9bc76eef557b9a769813bdf1e2741