Rename ANP DrawingModel to prevent conflict with AsyncDrawingModel

RESOLVED FIXED in Firefox 11

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bas, Assigned: bas)

Tracking

unspecified
mozilla12
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(firefox11 fixed)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 581514 [details] [diff] [review]
Rename DrawingModel to ANPDrawingModel

We're adding NPAPI async drawing code in a cross-platform manner in bug 651192. Recently we landed code that makes an android specific internal 'DrawingModel', that isn't based on the NPDrawingModel enumeration. We should rename this to not conflict with the new things we're adding based on the existing NPDrawingModel enum.

This patch I have is untested for lack of a current Android build env.
Attachment #581514 - Flags: review?(snorp)
Created attachment 589241 [details] [diff] [review]
Fixed up version of Bas' patch
Comment on attachment 581514 [details] [diff] [review]
Rename DrawingModel to ANPDrawingModel

You need nsNPAPIPluginInstance::GetANPDrawingModel() since nsPluginInstanceOwner::Paint() currently using GetDrawingModel() to get the ANP drawing model. Fixed and tested patch attached.
Attachment #581514 - Flags: review?(snorp) → review-
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3ac624ee524
https://hg.mozilla.org/mozilla-central/rev/e3ac624ee524
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Comment on attachment 589241 [details] [diff] [review]
Fixed up version of Bas' patch

[Triage Comment]
approval for beta to keep from having to rebase the rest of snorp's patches
Attachment #589241 - Flags: approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/10045c267ca1
status-firefox11: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.