710587 - runtests.py: update threadpool.py to newer version

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Tools, defect)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

Spawned off of Bug 710577.

runtests.py is currently masking exceptions thrown from our worker threads.

This is because threadpool.py is buggy; it does not enqueue exceptional results.

After I figured out the fix, I checked the origin website and found that the code there has been updated ($Revision: 416 $), dates from 2009; ours dates from 2008.  We should investigate plugging in the updated code.

(In the short term I plan to just drop in my fix, since I do not want to take the time to investigate whether the newer version works with our code base right now.)

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

(In reply to Felix S Klock II from comment #0)
> After I figured out the fix, I checked the origin website:

  http://chrisarndt.de/projects/threadpool/

  http://chrisarndt.de/projects/threadpool/threadpool.py.html

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Resolving this will also resolve the root problem documented on Bug 710577; namely, even calls to exit will be propogated to the main thread as exceptions, like so:

python runtests.py --avm ../../objdir-rel64/shell/avmshell --showtimes as3/Definitions/FunctionAccessors/AccessorSpray.as
Tamarin tests started: 2011-12-14 13:48:07.379264
current configuration: x64-mac-tvm-release
avm version: 6977:e0001d3effe4
thread count: 4
Executing 1 tests against vm: ../../objdir-rel64/shell/avmshell
  File "../util/threadpool.py", line 159, in run
    result = request.callable(*request.args, **request.kwds)
  File "runtests.py", line 272, in runTestPrep
    compileOutput = self.compile_test(ast, outputCalls=outputCalls)
  File "../util/runtestBase.py", line 1030, in compile_test
    exit('ERROR: builtin.abc (formerly global.abc) %s does not exist, BUILTINABC environment variable or --builtinabc must be set to builtin.abc' % builtinabc)
None
ERROR: builtin.abc (formerly global.abc)  does not exist, BUILTINABC environment variable or --builtinabc must be set to builtin.abc
(<type 'exceptions.SystemExit'>, SystemExit(1,), <traceback object at 0x1007af050>)

Comment 3

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: Patch E: local fix to exception issue

Fix for exception problem.

Note that this addition, by total coincidence, exactly matches the line that was added in the newer versions of threadpool.py:

  http://chrisarndt.de/projects/threadpool/threadpool.py.html

Comment 4

[Tamarin Bot]

changeset: 6788:3eb0397f8c85
user:      Felix S Klock II <[e-mail]>
summary:   Bug 710587: local fix to runtests.py exception issue (r=brbaker).

http://hg.mozilla.org/tamarin-redux/rev/3eb0397f8c85

Comment 5

[Felix S. Klock II [:pnkfelix, :fklock]]

(Despite scratching the itch that was bothering me in comment 4, I recommend this bug not be closed until someone has investigated updating our copy of threadpool.py, like the title says, or QE decides that such an investigation is not worth undertaking.)

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.