710824 - Product download page should handle invalid GET parameters

Status: RESOLVED FIXED

(www.mozilla.org :: Information Architecture & UX, defect)

Description

[raymond [:retornam] (inactive)]

Attachment: screenshot

STR:
1)  Visit http://www-dev.allizom.org/en-US/products/download.html in Firefox 8
2)  Notice that the page is broken

Comment 1

[Laura Forrest]

Yikes! 

James - can you take a look?

Comment 2

[Steven Garrity [:sgarrity]]

The layout could use a tweak, but this page is never linked to directly without the URL variables to trigger an actual download, so no one should actually be seeing this page.

To see this page in it's proper form, try any of the download buttons on mozilla.org/firefox

Comment 3

[Anthony Ricaud (:rik)]

This is not production and this is not a valid link to download. How did you arrive on this link?

Comment 4

[Fred Wenzel [:wenzel]]

Hm, why is the page hooked up to a URL anyway? Anthony's right, one should probably never arrive there.

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

FYI, this page is the one en-US uses for as a transition download page that triggers the download (mostly for metrics)
http://www.mozilla.org/products/download.html?product=firefox-8.0.1&os=linux&lang=en-US

It is used with GET parameters that will trigger the download via javascript.

It's an old page as indicates the /products/ part (back in 2005, our urls for products were /products/firefox/, /products/mozilla1x/, /products/thunderbird/, /products/camino/ ...).

For locales which had this page created several years later, we use a simpler url scheme:

http://www.mozilla.org/fr/download/?product=firefox-8.0.1&os=linux&lang=fr

In PHP, we have for locales a check for the validity of the parameters and if they are malformed or missing, the page redirects to the regular download page:

http://www.mozilla.org/fr/download/
redirects to http://www.mozilla.org/fr/firefox/

I suggest that the old en-US page is updated to have a similar behaviour.

That said, AFAIK we don't expose the URL without it's parameters anywhere therefore end users shouldn't meet this page.

Comment 6

[James Long (:jlongster)]

Changing the title because it was too dramatic. This is not a serious bug, the page has been that way for months/years.

Comment 8

[Kohei Yoshino [:kohei]]

My patch in Bug 887940 checks $_GET['product'] to resolve this issue as well.

Comment 9

[Kohei Yoshino [:kohei]]

This has been fixed in Bug 887940.