Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Certain dark Personas make it hard to read the selected tab title

RESOLVED FIXED in Thunderbird 12.0

Status

Thunderbird
Theme
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mconley, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 12.0
x86_64
Windows 7

Thunderbird Tracking Flags

(thunderbird11 fixed)

Details

Attachments

(3 attachments)

Created attachment 581749 [details]
Three Wolf Moon Persona reveals the issue

In the attached screenshot, a Three Wolf Moon Persona is making it difficult to read the Inbox tab title text.  We should make this much easier to read.
Paenglab:

Here`s another little bug, if you have time to tackle it.  If not, let me know.

-Mike
tracking-thunderbird11: --- → ?
Depends on: 644169
(Assignee)

Comment 2

6 years ago
I take it. Removing

.tabmail-tab:-moz-lwtheme[selected="true"] {
  text-shadow: none;
}

should make it.
Assignee: nobody → richard.marti
(Assignee)

Comment 3

6 years ago
Created attachment 582010 [details] [diff] [review]
Let the Personas shadow on Tab

Remove the text-shadow: none on active Tabs with Personas.
Attachment #582010 - Flags: ui-review?(bwinton)
Attachment #582010 - Flags: review?(mconley)
(Assignee)

Comment 4

6 years ago
Created attachment 582012 [details]
Comparison between Thunderbird and Firefox with the same Persona
Comment on attachment 582010 [details] [diff] [review]
Let the Personas shadow on Tab

That seems better.  I don't know whether it's better enough, but it's certainly good enough to get ui-r=me.  And since I'm here, I'll steal the review from Mike, and say r=me, too.

Thanks,
Blake.
Attachment #582010 - Flags: ui-review?(bwinton)
Attachment #582010 - Flags: ui-review+
Attachment #582010 - Flags: review?(mconley)
Attachment #582010 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

6 years ago
Comment on attachment 582010 [details] [diff] [review]
Let the Personas shadow on Tab

Asking for approval‑comm‑aurora because the ToT patch is also in comm-aurora.
Attachment #582010 - Flags: approval-comm-aurora?
Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/0c99685ae14e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #582010 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/9f5de3098224
status-thunderbird11: --- → fixed
tracking-thunderbird11: ? → ---
You need to log in before you can comment on or make changes to this bug.