Closed Bug 710838 Opened 8 years ago Closed 8 years ago

Certain dark Personas make it hard to read the selected tab title

Categories

(Thunderbird :: Theme, defect)

x86_64
Windows 7
defect
Not set

Tracking

(thunderbird11 fixed)

RESOLVED FIXED
Thunderbird 12.0
Tracking Status
thunderbird11 --- fixed

People

(Reporter: mconley, Assigned: Paenglab)

References

Details

Attachments

(3 files)

In the attached screenshot, a Three Wolf Moon Persona is making it difficult to read the Inbox tab title text.  We should make this much easier to read.
Paenglab:

Here`s another little bug, if you have time to tackle it.  If not, let me know.

-Mike
I take it. Removing

.tabmail-tab:-moz-lwtheme[selected="true"] {
  text-shadow: none;
}

should make it.
Assignee: nobody → richard.marti
Remove the text-shadow: none on active Tabs with Personas.
Attachment #582010 - Flags: ui-review?(bwinton)
Attachment #582010 - Flags: review?(mconley)
Comment on attachment 582010 [details] [diff] [review]
Let the Personas shadow on Tab

That seems better.  I don't know whether it's better enough, but it's certainly good enough to get ui-r=me.  And since I'm here, I'll steal the review from Mike, and say r=me, too.

Thanks,
Blake.
Attachment #582010 - Flags: ui-review?(bwinton)
Attachment #582010 - Flags: ui-review+
Attachment #582010 - Flags: review?(mconley)
Attachment #582010 - Flags: review+
Keywords: checkin-needed
Comment on attachment 582010 [details] [diff] [review]
Let the Personas shadow on Tab

Asking for approval‑comm‑aurora because the ToT patch is also in comm-aurora.
Attachment #582010 - Flags: approval-comm-aurora?
Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/0c99685ae14e
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #582010 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.