Closed
Bug 710842
Opened 13 years ago
Closed 13 years ago
Please re-enable symbols for nightly Fennec XUL builds
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: laura, Assigned: mozilla)
References
Details
Attachments
(1 file)
6.73 KB,
patch
|
bhearsum
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
We need them for crash-stats, as per CrashKill team. These builds will be primary on tablets for some time to come.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → aki
Assignee | ||
Comment 1•13 years ago
|
||
Written to apply on top of the patch in bug 710453. * Reenabled symbols for android-xul * Changed the MOZ_SYMBOLS_EXTRA_BUILDID so android and android-xul symbols don't conflict * Added the missing del linux-android[-debug] lines for mozilla-beta and mozilla-release (not really part of this bug, but what's an Aki patch without ridealongs)
Attachment #583264 -
Flags: review?(bhearsum)
Comment 2•13 years ago
|
||
Comment on attachment 583264 [details] [diff] [review] reenable android-xul symbols Review of attachment 583264 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozilla/config.py @@ +1244,5 @@ > BRANCHES['mozilla-central']['blocklist_update_on_closed_tree'] = False > BRANCHES['mozilla-central']['platforms']['linux-rpm']['enable_nightly'] = True > BRANCHES['mozilla-central']['platforms']['linux64-rpm']['enable_nightly'] = True > BRANCHES['mozilla-central']['platforms']['android']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'mozilla-central' > +BRANCHES['mozilla-central']['platforms']['android-xul']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-xul-mozilla-central' We don't need to put the branch in here, because the symbol paths already include the version number. r+ anyways, but please file a follow to get rid of this for the android platforms. @@ +1473,5 @@ > BRANCHES['mozilla-aurora']['enable_valgrind'] = False > del BRANCHES['mozilla-aurora']['platforms']['linux-android'] > del BRANCHES['mozilla-aurora']['platforms']['linux-android-debug'] > BRANCHES['mozilla-aurora']['platforms']['android']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'mozilla-aurora' > +BRANCHES['mozilla-aurora']['platforms']['android-xul']['env']['MOZ_SYMBOLS_EXTRA_BUILDID'] = 'android-xulmozilla-aurora' Needs a hyphen between "xul" and "mozilla".
Attachment #583264 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 583264 [details] [diff] [review] reenable android-xul symbols http://hg.mozilla.org/build/buildbot-configs/rev/28c820fe2b2a
Attachment #583264 -
Flags: checked-in+
Assignee | ||
Comment 4•13 years ago
|
||
Android-xul symbols will be reenabled on the next reconfig, which is scheduled for tomorrow (Thursday). Filed bug 712675 for the cleanup in comment 2.
Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•