710925 - Add edit menu to the style editor

Status: RESOLVED WONTFIX

(DevTools :: Style Editor, defect, P2)

Description

[Dave Camp (:dcamp)]

Seems useful/mandatory for navigating a large stylesheet.  Paul has been asked about this a couple times on twitter.

Mihai, is there decent support for this in Orion?

Comment 1

[Dave Camp (:dcamp)]

As paul mentioned on irc, Find is what we really need.  Replace can be left for a followup.

Comment 2

[Mihai Sucan [:msucan]]

This is not going to be fixed by bug 650345. Based on a technical decision now the Style Editor needs an Edit menu with UI to access the Find and Find again commands. Bug 650345 adds all of the functionality needed into the Source Editor and you can see how I added the commands to Scratchpad - should be easy to do the same with the Style Editor.

Please let me know if you have any questions. Thanks Mike!

Comment 3

[Kevin Dangoor]

Will this bug also cover "jump to line"? or does that need a separate bug?

Comment 4

[Mihai Sucan [:msucan]]

The patch from bug 684445 adds a default context menu to the style editor and it makes changes to the styleeditor.xul file as needed. Mike, I suggest you look into that patch - I believe you need those changes for your work with the Style Editor Edit menu. With that patch applied you have less work to do: just add the menupopup with the xul:menuitems with the right commands and keys associated - most commands and keys are made available.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Wow, that is a dependency tree

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Updating the title of this bug so that it matches the direction that this bug has taken.

The edit menu has the following items:
- Undo
- Redo
- Cut
- Copy
- Paste
- Select All
- Find
- Find Again
- Goto Line

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Edit menu unselected

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Edit menu selected

Comment 9

[Cedric Vivier [:cedricv]]

Attachment: regular menu

I think menus inside a toolbar looks 'out of place'.
How about a regular menu like this attachment? (and we can add File in a follow-up)

Comment 10

[Cedric Vivier [:cedricv]]

ie.(In reply to Cedric Vivier [:cedricv] from comment #9)
> I think menus inside a toolbar looks 'out of place'.
> How about a regular menu like this attachment? (and we can add File in a
> follow-up)

The regular 'full' menu will be only shown when the Style Editor is extracted in its own window.

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Edit menu with no styling

I was asked to remove all styling so I have logged bug 727794 for this.

Comment 12

[Cedric Vivier [:cedricv]]

Also as we discussed on IRC, we might prefer to rely on context menu in the editor only, to keep the UI light.

Asking feedback to shorlander.

Comment 13

[Cedric Vivier [:cedricv]]

The initial description of the bug seems to be primarily about exposing 'Find' - having a searchbox at the right of the editor toolbar might be more discoverable and less noisy.

Comment 14

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Maybe, but the jump to line etc. are not very discoverable

Comment 15

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Edit menu with no styling

I have moved the edit menu to the top a la scratchpad.

Comment 16

[Mihai Sucan [:msucan]]

Comment on attachment 597850 [details] [diff] [review]
Edit menu with no styling

Review of attachment 597850 [details] [diff] [review]:
-----------------------------------------------------------------

/me likes! Thanks for your patch Mike!

Pending UI review/feedback from shorlander, this can land. If shorlander decides we need to move these commands into the context menu - to not add a new Edit menu - we can do that easily in bug 684445.

Shorlander: please check this stuff and let us know what's the best way to go forward with the Style Editor UI. Thank you!

Comment 17

[Paul Rouget [:paul]]

Comment on attachment 597850 [details] [diff] [review]
Edit menu with no styling

For Linux and Windows, we can't get an additional toolbar.

80% of the original toolbar is empty. Here, we're adding another toolbar that is 90% empty.
This is a waste of space. Also, this won't work once the StyleEditor will be located in the sidebar.

I understand the rational here, but adding a toolbar doesn't look like the right approach.
A context menu sounds better to me.

But then comes the discoverability problem:

These options:
- Undo
- Redo
- Cut
- Copy
- Paste
- Select All
…don't need to be too much discoverable since everybody already know how to use them.

About these items:
- Find
- Find Again
- Goto Line

Find and Find Again use the same binding as the browser. About Goto Line, I believe that the user will need to use the context menu before needing these features, so he will learn about it sooner or later.

Comment 18

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Discussed this with robcee ... we can just use a context menu instead.

Comment 19

[Rob Campbell [:rc] (:robcee)]

yeah, I'm inclined to go with a Context menu here unless we have more than just an Edit menu in the menubar. It also becomes easier to manage when the Style Editor's docked in the browser; we don't have a bunch of menues that we need to somehow wedge into the main browser UI. And it forces us to keep things simple with just the context menu and eliminates the need to add custom styling for menubars.

Comment 20

[Mihai Sucan [:msucan]]

Agreed. I also discussed this with Rob and I'll update the patch for Bug 684445 to include Find, Find again and Jump to line in the default list of Source Editor context menu items.

Comment 21

[Stephen Horlander [:shorlander]]

Comment on attachment 597850 [details] [diff] [review]
Edit menu with no styling

Review of attachment 597850 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Rob Campbell [:rc] (robcee) from comment #19)
> yeah, I'm inclined to go with a Context menu here unless we have more than
> just an Edit menu in the menubar. It also becomes easier to manage when the
> Style Editor's docked in the browser; we don't have a bunch of menues that
> we need to somehow wedge into the main browser UI. And it forces us to keep
> things simple with just the context menu and eliminates the need to add
> custom styling for menubars.

I agree with all of that.

Comment 22

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Mihai Sucan [:msucan] from comment #20)
> Agreed. I also discussed this with Rob and I'll update the patch for Bug
> 684445 to include Find, Find again and Jump to line in the default list of
> Source Editor context menu items.

As we are all in agreement and Mihai has updated the context menu in his updated patch for bug 684445 I will close this bug?