Last Comment Bug 710958 - Remove gfx{Glitz,DirectFB,QuartzPDF}Surface
: Remove gfx{Glitz,DirectFB,QuartzPDF}Surface
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: ImageLib (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Nicholas Nethercote [:njn]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-14 20:43 PST by Nicholas Nethercote [:njn]
Modified: 2012-01-04 04:49 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (50.23 KB, patch)
2011-12-18 18:48 PST, Nicholas Nethercote [:njn]
joe: review+
Details | Diff | Splinter Review

Description Nicholas Nethercote [:njn] 2011-12-14 20:43:35 PST
gfx{Glitz,PS,QuartzPDF}Surface are never used, AFAICT.  And gfxDirectFBSurface is only used if MOZ_DMD=1;  this can happen in configure.in, but roc says it doesn't work.
Comment 1 Nicholas Nethercote [:njn] 2011-12-14 20:55:02 PST
Stuart informs me that gfxPSSurface is still used by some printing code.
Comment 2 Nicholas Nethercote [:njn] 2011-12-14 23:54:03 PST
I started doing this.  I obviously need to remove the Glitz/DirectFB/QuartzPDF surface stuff in gfx/thebes/.  Should I remove all traces of Glitz/DirectFB stuff in gfx/cairo/ as well?
Comment 3 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-12-15 00:42:28 PST
You should make sure it's not built. But cairo is an upstream project so we should avoid making unnecessary changes like removing things we don't use.
Comment 4 Nicholas Nethercote [:njn] 2011-12-18 18:48:30 PST
Created attachment 582730 [details] [diff] [review]
patch

The patch removes the relevant files plus all mentions of MOZ_DFB, and
everything that looks related.  It looks good on the try server.

I confirmed that cairo-glitz-surface.c and cairo-directfb-surface.c aren't
being compiled on debug linux64 builds.

There's a comment remaining in widget/src/gtk2/nsWindow.cpp that mentions
DirectFB ("Disable the double buffer..."), not sure what to do with that.

Here are the diffstats:

 b/config/autoconf.mk.in                  |    1 
 b/config/system-headers                  |    5 -
 b/configure.in                           |   24 -----
 b/dom/plugins/ipc/PluginModuleChild.cpp  |    3 
 b/gfx/thebes/Makefile.in                 |   13 --
 b/gfx/thebes/gfxASurface.cpp             |   13 --
 b/gfx/thebes/gfxASurface.h               |    4 
 b/gfx/thebes/gfxGdkNativeRenderer.cpp    |   53 -----------
 b/gfx/thebes/gfxPlatformGtk.cpp          |   15 ---
 b/js/src/config/system-headers           |    5 -
 b/widget/src/gtk2/nsBidiKeyboard.cpp     |    3 
 b/widget/src/gtk2/nsScreenManagerGtk.cpp |   21 ----
 b/widget/src/gtk2/nsWindow.cpp           |  126 --------------------------
 b/widget/src/gtk2/nsWindow.h             |   12 --
 gfx/thebes/cairo-gdk-utils.c             |  107 ----------------------
 gfx/thebes/cairo-gdk-utils.h             |  119 -------------------------
 gfx/thebes/gfxDirectFBSurface.cpp        |  147 -------------------------------
 gfx/thebes/gfxDirectFBSurface.h          |   69 --------------
 gfx/thebes/gfxGlitzSurface.h             |   73 ---------------
 gfx/thebes/gfxQuartzPDFSurface.cpp       |   93 -------------------
 gfx/thebes/gfxQuartzPDFSurface.h         |   74 ---------------
 21 files changed, 4 insertions(+), 976 deletions(-)
Comment 5 Nicholas Nethercote [:njn] 2012-01-03 16:17:37 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ca7f53b9775
Comment 6 Marco Bonardo [::mak] 2012-01-04 04:49:25 PST
https://hg.mozilla.org/mozilla-central/rev/9ca7f53b9775

Note You need to log in before you can comment on or make changes to this bug.