Closed Bug 710958 Opened 8 years ago Closed 8 years ago

Remove gfx{Glitz,DirectFB,QuartzPDF}Surface

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

gfx{Glitz,PS,QuartzPDF}Surface are never used, AFAICT.  And gfxDirectFBSurface is only used if MOZ_DMD=1;  this can happen in configure.in, but roc says it doesn't work.
Stuart informs me that gfxPSSurface is still used by some printing code.
Summary: Remove gfx{Glitz,DirectFB,PS,QuartzPDF}Surface → Remove gfx{Glitz,DirectFB,QuartzPDF}Surface
I started doing this.  I obviously need to remove the Glitz/DirectFB/QuartzPDF surface stuff in gfx/thebes/.  Should I remove all traces of Glitz/DirectFB stuff in gfx/cairo/ as well?
You should make sure it's not built. But cairo is an upstream project so we should avoid making unnecessary changes like removing things we don't use.
Attached patch patchSplinter Review
The patch removes the relevant files plus all mentions of MOZ_DFB, and
everything that looks related.  It looks good on the try server.

I confirmed that cairo-glitz-surface.c and cairo-directfb-surface.c aren't
being compiled on debug linux64 builds.

There's a comment remaining in widget/src/gtk2/nsWindow.cpp that mentions
DirectFB ("Disable the double buffer..."), not sure what to do with that.

Here are the diffstats:

 b/config/autoconf.mk.in                  |    1 
 b/config/system-headers                  |    5 -
 b/configure.in                           |   24 -----
 b/dom/plugins/ipc/PluginModuleChild.cpp  |    3 
 b/gfx/thebes/Makefile.in                 |   13 --
 b/gfx/thebes/gfxASurface.cpp             |   13 --
 b/gfx/thebes/gfxASurface.h               |    4 
 b/gfx/thebes/gfxGdkNativeRenderer.cpp    |   53 -----------
 b/gfx/thebes/gfxPlatformGtk.cpp          |   15 ---
 b/js/src/config/system-headers           |    5 -
 b/widget/src/gtk2/nsBidiKeyboard.cpp     |    3 
 b/widget/src/gtk2/nsScreenManagerGtk.cpp |   21 ----
 b/widget/src/gtk2/nsWindow.cpp           |  126 --------------------------
 b/widget/src/gtk2/nsWindow.h             |   12 --
 gfx/thebes/cairo-gdk-utils.c             |  107 ----------------------
 gfx/thebes/cairo-gdk-utils.h             |  119 -------------------------
 gfx/thebes/gfxDirectFBSurface.cpp        |  147 -------------------------------
 gfx/thebes/gfxDirectFBSurface.h          |   69 --------------
 gfx/thebes/gfxGlitzSurface.h             |   73 ---------------
 gfx/thebes/gfxQuartzPDFSurface.cpp       |   93 -------------------
 gfx/thebes/gfxQuartzPDFSurface.h         |   74 ---------------
 21 files changed, 4 insertions(+), 976 deletions(-)
Assignee: nobody → nnethercote
Attachment #582730 - Flags: review?(joe)
Attachment #582730 - Flags: review?(joe) → review+
https://hg.mozilla.org/mozilla-central/rev/9ca7f53b9775
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.