Closed
Bug 711012
Opened 13 years ago
Closed 12 years ago
[ja] Searchplugins for Thunderbird
Categories
(Mozilla Localizations :: ja / Japanese, defect)
Mozilla Localizations
ja / Japanese
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: marsf, Unassigned)
Details
(Keywords: productization)
Attachments
(1 file, 1 obsolete file)
31.33 KB,
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.2.24) Gecko/20111103 Firefox/3.6.24 Build ID: 20111103063747 Steps to reproduce: For Thunderbird, we use same searchplugins as in Firefox. (Currently, pushed searchplugins are same with en-US.) I've referred to Bug 702277 ([fr]), and just commented out "sourceid" and "MozParam" parameters from all searchplugins.
Reporter | ||
Updated•13 years ago
|
Keywords: productization
Updated•12 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 1•12 years ago
|
||
Comment on attachment 581913 [details] [diff] [review] tb10-searchplugins-ja.diff >diff --git a/ja/mail/chrome/messenger-region/region.properties b/ja/mail/chrome/messenger-region/region.properties > browser.search.order.1 = Google >-browser.search.order.2 = Yahoo >-browser.search.order.3 = Bing >+browser.search.order.2 = Yahoo! JAPAN >+browser.search.order.3 = Amazon.co.jp >+browser.search.order.4 = 楽天å¸å ´ >+browser.search.order.5 = Yahoo!ãªã¼ã¯ã·ã§ã³ >+browser.search.order.6 = æãã¦ï¼goo >+browser.search.order.7 = Wikipedia (ja) >+browser.search.order.8 = Creative Commons I don't see Creative Commons in list.txt, so I don't think you need it in the search order. >diff --git a/ja/mail/searchplugins/oshiete-goo.xml b/ja/mail/searchplugins/oshiete-goo.xml >+<Url type="text/html" method="GET" template="http://oshiete1.goo.ne.jp/goo_search.php3"> >+ <Param name="MT" value="{searchTerms}"/> >+ <Param name="from" value="Firefox30"/> >+ <Param name="PT" value="Firefox30"/> >+</Url> Can you drop the from and PT params for now please? Whilst we check what is right for Thunderbird. >diff --git a/ja/mail/searchplugins/twitter-ja.xml b/ja/mail/searchplugins/twitter-ja.xml >+ <Param name="partner" value="Firefox"/> >+ <Param name="source" value="desktop-search"/> Please drop these paramters for now. r=Standard8 with that fixed. I'm approving your landings on aurora before the merge, so please make sure you land this on beta as well after the merge (especially as you shouldn't really put en-US files into your searchplugins directory, but that's ok by me for now as this patch will remove them.
Attachment #581913 -
Flags: review+
Reporter | ||
Comment 2•12 years ago
|
||
> diff --git a/ja/mail/chrome/messenger-region/region.properties b/ja/mail/chrome/messenger-region/region.properties
> +browser.search.order.7 = Twitter
> +browser.search.order.8 = Wikipedia (ja)
Removed "Creative Commons" and added "Twitter".
BTW, you've found the another bug that we must fix in browser/region.properties.
And commented out the params in oshiete-goo.xml and twitter-ja.xml.
Attachment #581913 -
Attachment is obsolete: true
Reporter | ||
Comment 3•12 years ago
|
||
Aurora (ja/ja-JP-mac): http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/5788ca631618 http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/b915cb7caa63 Beta (ja/ja-JP-mac): http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/4627a7bea107 http://hg.mozilla.org/releases/l10n/mozilla-beta/ja-JP-mac/rev/574f33cbe472
Comment 4•12 years ago
|
||
Thanks, I believe this is fixed now.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•