Closed
Bug 711029
Opened 13 years ago
Closed 13 years ago
move the keep-duration-button's images inside the calendar-event-dialog.png file
Categories
(Calendar :: Dialogs, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4
People
(Reporter: bv1578, Assigned: bv1578)
Details
Attachments
(2 files)
The file event-dialog-keepduration-button.png has to be deleted and the button's icons have to be added to the icons inside the file calendar-event-dialog.png.
This was requested in bug 366139 comment #50.
Philipp, I ask Richard Marti for review, but since I've also deleted the three files calendar-event-dialog.png from themes/*stripe/dialogs/images (three identical files for every theme) and created a unique new file in a new directory "images" inside themes/common/dialogs, you have to say if it's right doing in that way.
If it's planned to adapt the icons inside calendar-event-dialog.png to the different themes, I can add the new icons to every files in the original position.
Attachment #581942 -
Flags: review?(richard.marti)
Comment 3•13 years ago
|
||
Comment on attachment 581942 [details] [diff] [review]
patch
This looks good.
Let's see what Philipp says with using the common file.
Attachment #581942 -
Flags: review?(richard.marti) → review+
Comment 4•13 years ago
|
||
Comment on attachment 581942 [details] [diff] [review]
patch
Common file is fine for me
Attachment #581942 -
Flags: feedback+
Keywords: checkin-needed
Updated•13 years ago
|
Keywords: checkin-needed
Comment 5•13 years ago
|
||
Pushed to comm-central changeset 899c2df75f2d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4
You need to log in
before you can comment on or make changes to this bug.
Description
•