MOZ_VERIFY_MAR_SIGNATURE build option for verifying MAR signatures

RESOLVED FIXED in Firefox 12

Status

()

Product:
Toolkit
Component:
Application Update
RESOLVED FIXED
Reported:
6 years ago
Modified:
5 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

Version:
unspecified
Target:
mozilla12
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 unaffected, firefox12 fixed, firefox13 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

Patch v2.
3.84 KB, patch
rstrong
: review+
khuey
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

•
6 years ago 
Add a new build option MOZ_VERIFY_MAR_SIGNATURE which is set in confvars.sh on Windows.

This option should be off by default but can be opted in with --enable-verify-mar-signature in .mozconfig.
 (Assignee)

Updated

•
6 years ago
Summary: Build option for verifying MAR signatures → MOZ_VERIFY_MAR_SIGNATURE build option for verifying MAR signatures
 (Assignee)

Comment 1

•
6 years ago 
Created attachment 588027 [details] [diff] [review]
Patch v1.

I'll do a sr from khuey if this gets an r+.
Attachment #588027 - Flags: review?(robert.bugzilla)

Comment 2

•
6 years ago 
Comment on attachment 588027 [details] [diff] [review]
Patch v1.

What about /config/autoconf.mk.in?
Attachment #588027 - Flags: review?(robert.bugzilla) → review-
 (Assignee)

Comment 3

•
6 years ago 
Created attachment 589738 [details] [diff] [review]
Patch v2.

Nice catch, thx.
Attachment #588027 - Attachment is obsolete: true
Attachment #589738 - Flags: review?(robert.bugzilla)
Attachment #589738 - Flags: review?(robert.bugzilla) → review+
 (Assignee)

Updated

•
6 years ago
Attachment #589738 - Flags: superreview?(khuey)
Attachment #589738 - Flags: superreview?(khuey) → superreview+
 (Assignee)

Updated

•
6 years ago
Depends on: 728935
 (Assignee)

Updated

•
6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
 (Assignee)

Comment 4

•
6 years ago 
http://hg.mozilla.org/mozilla-central/rev/ef967515537b
 (Assignee)

Comment 5

•
6 years ago 
http://hg.mozilla.org/releases/mozilla-aurora/rev/18840d884c97
status-firefox11: --- → unaffected
status-firefox12: --- → fixed
Target Milestone: mozilla13 → mozilla12
 (Assignee)

Updated

•
6 years ago
status-firefox13: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.