Closed Bug 711139 Opened 10 years ago Closed 10 years ago

MOZ_VERIFY_MAR_SIGNATURE build option for verifying MAR signatures

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12
Tracking Flags:
Tracking Status
firefox11 --- unaffected
firefox12 --- fixed
firefox13 --- fixed

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Patch v2.
3.84 KB, patch
robert.strong.bugs
: review+
khuey
: superreview+
Details | Diff | Splinter Review 
Add a new build option MOZ_VERIFY_MAR_SIGNATURE which is set in confvars.sh on Windows.

This option should be off by default but can be opted in with --enable-verify-mar-signature in .mozconfig.
Summary: Build option for verifying MAR signatures → MOZ_VERIFY_MAR_SIGNATURE build option for verifying MAR signatures
Attached patch Patch v1. (obsolete) — — Splinter Review 
I'll do a sr from khuey if this gets an r+.
Attachment #588027 - Flags: review?(robert.bugzilla)
Comment on attachment 588027 [details] [diff] [review]
Patch v1.

What about /config/autoconf.mk.in?
Attachment #588027 - Flags: review?(robert.bugzilla) → review-
Attached patch Patch v2. — — Splinter Review 
Nice catch, thx.
Attachment #588027 - Attachment is obsolete: true
Attachment #589738 - Flags: review?(robert.bugzilla)
Attachment #589738 - Flags: review?(robert.bugzilla) → review+
Attachment #589738 - Flags: superreview?(khuey)
Attachment #589738 - Flags: superreview?(khuey) → superreview+
Depends on: 728935
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
status-firefox13: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.