Last Comment Bug 711144 - LD_LIBRARY_PATH should be prepended, not appended
: LD_LIBRARY_PATH should be prepended, not appended
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: All Linux
: -- normal (vote)
: mozilla12
Assigned To: Mike Hommey [:glandium]
:
: [PTO to Dec5] Bill McCloskey (:billm)
Mentors:
Depends on:
Blocks: 714156 573958
  Show dependency treegraph
 
Reported: 2011-12-15 10:11 PST by Mike Hommey [:glandium]
Modified: 2011-12-29 15:34 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Prepend LD_LIBRARY_PATH instead of appending to it when starting plugin-container (1.43 KB, patch)
2011-12-16 02:44 PST, Mike Hommey [:glandium]
benjamin: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2011-12-15 10:11:13 PST
Bug 573958 changed the way plugin-container sets up LD_LIBRARY_PATH by appending instead of replacing its value. It should in fact prepend instead of append. There are edge cases where it may pick libxul or other libraries from another gecko directory that is in LD_LIBRARY_PATH.
Comment 1 Mike Hommey [:glandium] 2011-12-16 02:44:26 PST
Created attachment 582222 [details] [diff] [review]
Prepend LD_LIBRARY_PATH instead of appending to it when starting plugin-container
Comment 3 Matt Brubeck (:mbrubeck) 2011-12-28 11:13:12 PST
https://hg.mozilla.org/mozilla-central/rev/f7279332f966

Note You need to log in before you can comment on or make changes to this bug.