nsXPConnect::BeginCycleCollection ignores JS_SetContextThread failures

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
7 years ago
5 years ago

People

(Reporter: mccr8, Unassigned)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
timeless reported a crash in begin cycle collection:

http://pastebin.mozilla.org/1406820

He said it looks like it is due to an OOM in JS_SetContextThread (JS reported OOM).  The return of this call is not checked, so it crashes right after that.  I'm not sure if there's any graceful way to recover, because it seems like we'd have to abort the entire cycle collection, and begin that downward spiral.

This is kind of a secondary effect of the IRCcloud memory leak, I think.
(Reporter)

Comment 1

7 years ago
Created attachment 582092 [details]
crash information
(Reporter)

Comment 2

5 years ago
CC thread is gone.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Depends on: 901630
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.