711246 - [Upgrade 3.6 Landing Page] Bookmarks & Browsing Page

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[mcbmoz]

jbalogh, can you submit your patch from http://moz.jbalogh.me/en-US/firefox/bookmarks/ here for James.

Wiki: https://wiki.mozilla.org/Mozilla.org/Roadmap_2011/Q4/3.6-Upgrade

Comment 1

[Jeff Balogh (:jbalogh)]

Attachment: js/css to make the stars move

I'll attach the new images separately since that doesn't seem to be a thing in svn.

Comment 2

[Jeff Balogh (:jbalogh)]

Attachment: Drop this in img/covehead/firefox/bookmarks/star.png

Comment 3

[Jeff Balogh (:jbalogh)]

Attachment: Drop this in img/covehead/firefox/bookmarks/cloud.png

Sorry about the jankiness of this patch jlongster.

Comment 4

[James Long (:jlongster)]

I'll try to apply this tonight, thanks!

Comment 5

[James Long (:jlongster)]

Comment on attachment 582134 [details] [diff] [review]
js/css to make the stars move

Review of attachment 582134 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but I'd used requestAnimationFrame instead of setInterval. I'll r+ this and replace it myself while patching.

Comment 6

[James Long (:jlongster)]

on trunk r99188, please test it.

Comment 7

[Jeff Balogh (:jbalogh)]

(In reply to James Long (:jlongster) from comment #5)
> Looks good, but I'd used requestAnimationFrame...

That's not available in 3.6, which this page is targeting.

Comment 8

[James Long (:jlongster)]

(In reply to James Long (:jlongster) from comment #5)
> Looks good, but I'd used requestAnimationFrame instead of setInterval. I'll
> r+ this and replace it myself while patching.

Nevermind that, just noticed it's just a few setTimeouts so that's cool.

Comment 9

[James Long (:jlongster)]

(In reply to Jeff Balogh (:jbalogh) from comment #7)
> (In reply to James Long (:jlongster) from comment #5)
> > Looks good, but I'd used requestAnimationFrame...
> 
> That's not available in 3.6, which this page is targeting.

Ok, I read the code wrong anyway. Look good on dev?

Comment 10

[Jeff Balogh (:jbalogh)]

(In reply to James Long (:jlongster) from comment #9)
> Ok, I read the code wrong anyway. Look good on dev?

It works on Nightly. Thanks for landing this jlongster.

Comment 11

[James Long (:jlongster)]

(In reply to Jeff Balogh (:jbalogh) from comment #10)
> (In reply to James Long (:jlongster) from comment #9)
> > Ok, I read the code wrong anyway. Look good on dev?
> 
> It works on Nightly. Thanks for landing this jlongster.

np. Our beards combined... in r99194 on production

Comment 12

[raymond [:retornam] (inactive)]

qa-verified-trunk http://www-dev.allizom.org/en-US/firefox/bookmarks/

Comment 13

[raymond [:retornam] (inactive)]

verified fixed http://www.mozilla.org/en-US/firefox/bookmarks/