711277 - Fix page arguments system

Status: RESOLVED WONTFIX

(Tree Management Graveyard :: OrangeFactor, defect)

Description

[Mark Côté [:mcote]]

The way we process page arguments and convert them from search string to controls and back doesn't entirely make sense.

I've already split off the "global" controls (those that should be preserved across page changes, such as tree, date range, and most filters) and stored them in PageLoader.  However the "local" controls that only make sense on the current page (such as bugid on the Bug Details view) are still scattered around.  It is held together by the fact that every global control has a reference to the central args dictionary, meaning that every global control knows about all arguments.  This is just silly.

Instead, PageLoader should also know about local controls.  When the same page is reloaded, PageLoader should check the local and global controls, and when a new page is loaded, it should use only global controls.

We probably don't need to pass in the name/value of arguments that changed; we should be able to grab this from the local and global control objects.

Comment 1

[Mark Côté [:mcote]]

This was never high priority, and I haven't gotten to it in over a year, so unassigning myself.

Comment 2

[Ed Morley [:emorley]]

Wontfix since OrangeFactor is going away in favour of a replacement built into Treeherder (bug 1367362).