Last Comment Bug 711357 - leaking a CGFontRef during activation of a downloadable font
: leaking a CGFontRef during activation of a downloadable font
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla11
Assigned To: Jonathan Kew (:jfkthame)
:
:
Mentors:
Depends on:
Blocks: clang-analysis 711301
  Show dependency treegraph
 
Reported: 2011-12-16 02:13 PST by Jonathan Kew (:jfkthame)
Modified: 2011-12-20 09:58 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
release the CGFontRef after creating our font entry (which will retain its own reference) (959 bytes, patch)
2011-12-16 02:13 PST, Jonathan Kew (:jfkthame)
jd.bugzilla: review+
Details | Diff | Splinter Review

Description Jonathan Kew (:jfkthame) 2011-12-16 02:13:20 PST
Created attachment 582216 [details] [diff] [review]
release the CGFontRef after creating our font entry (which will retain its own reference)

The static analysis is correct again, AFAICT:
http://people.mozilla.org/~gszorc/clang/2011-12-15-13/report-LNeOzf.html#EndPath
Comment 1 John Daggett (:jtd) 2011-12-18 12:35:25 PST
Comment on attachment 582216 [details] [diff] [review]
release the CGFontRef after creating our font entry (which will retain its own reference)

wow, great that we're catching these using an automated tool!
Comment 3 Marco Bonardo [::mak] 2011-12-19 08:38:26 PST
https://hg.mozilla.org/mozilla-central/rev/302f1762b2b2

Note You need to log in before you can comment on or make changes to this bug.