711421 - Search: counting plugin crashes is wrong

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[[DEACTIVATED] Adrian Gaudebert]

Before we added content crashes, counting for plugin crashes was simply counting the number of non-empty process_type fields. Now that we discern the content of that process_type field, we need to change this. Otherwise content crashes will appear as plugin crashes as well.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Test case for this: 

1. Go to /query (advanced search)
2. Search for any Fennec version with report process = content
3. Check that all crashes have the content icon, and not the browser icon (place your mouse on the icon to know what it represents)

Comment 2

[[github robot]]

Commits pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/55c1b2c790a29cff8d28b20f6c2dfdcc5dbdbe62
Fixes bug 711421 - Fix counting plugin crashes in search.

https://github.com/mozilla/socorro/commit/5950e5170d3a8942bd597173fcf5768bf492c2ab
Merge pull request #233 from AdrianGaudebert/711421-search-plugin-crashes

Fixes bug 711421 - Fix counting plugin crashes in search.

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

To QA: 

It is expected that there is no content crash for FennecAndroid.

Steps to QA:
------------

1. Go to https://crash-stats-dev.allizom.org/query
2. Search for Fennec crashes
3. Click on a signature with the content icon
4. In the Reports tab, check that there is at least once that icon in the Crash Type column
5. Do the same with a signature without the content icon and check that there is no icon in report/list.

Comment 4

[Matt Brandt [:mbrandt]]

QA verified on stage: thx for the easy to follow steps to verify in comment 3
All Fennec content crashers that I checked contain the content icon.