Closed Bug 711478 Opened 9 years ago Closed 9 years ago

Windows PGO builds building without profiling data

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
mozilla11

People

(Reporter: ted, Assigned: Gavin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

bug 696436 made an inadvertent change that made us run the PGO profiling run from $(DIST)/bin instead of from $(DIST)/firefox like we're supposed to. This means that we don't actually get any of the profiling data into the optimizer.
http://hg.mozilla.org/mozilla-central/rev/6b18f5259de9#l14.12

(This broke because we expect the PGC files to wind up in $(DIST)/firefox, so we do:
rm -f ./dist/bin/*.pgc
find ./dist/firefox -name "*.pgc" -exec mv {} ./dist/bin

Ed Morley noticed this while looking at the results from bug 710712.

We need to fix that hunk of the patch.
Attached patch patchSplinter Review
I just didn't realize that this was overriding the value from the included file.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #582308 - Flags: review?(ted.mielczarek)
Comment on attachment 582308 [details] [diff] [review]
patch

Review of attachment 582308 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, let's just do this.
Attachment #582308 - Flags: review?(ted.mielczarek) → review+
Also, I totally missed this in reviewing your original patch, so this falls on me too.
Blocks: 711527
http://hg.mozilla.org/mozilla-central/rev/3749f921ee90
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.