Windows PGO builds building without profiling data

RESOLVED FIXED in mozilla11

Status

()

Core
Build Config
--
blocker
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ted, Assigned: Gavin)

Tracking

(Blocks: 1 bug)

Trunk
mozilla11
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
bug 696436 made an inadvertent change that made us run the PGO profiling run from $(DIST)/bin instead of from $(DIST)/firefox like we're supposed to. This means that we don't actually get any of the profiling data into the optimizer.
http://hg.mozilla.org/mozilla-central/rev/6b18f5259de9#l14.12

(This broke because we expect the PGC files to wind up in $(DIST)/firefox, so we do:
rm -f ./dist/bin/*.pgc
find ./dist/firefox -name "*.pgc" -exec mv {} ./dist/bin

Ed Morley noticed this while looking at the results from bug 710712.

We need to fix that hunk of the patch.
Created attachment 582308 [details] [diff] [review]
patch

I just didn't realize that this was overriding the value from the included file.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #582308 - Flags: review?(ted.mielczarek)
(Reporter)

Comment 2

6 years ago
Comment on attachment 582308 [details] [diff] [review]
patch

Review of attachment 582308 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, let's just do this.
Attachment #582308 - Flags: review?(ted.mielczarek) → review+
(Reporter)

Comment 3

6 years ago
Also, I totally missed this in reviewing your original patch, so this falls on me too.
(Reporter)

Updated

6 years ago
Blocks: 711527
http://hg.mozilla.org/mozilla-central/rev/3749f921ee90
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.