711487 - User Agent Override May Disable the Source Editor (with Orion)

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect, P3)

Description

[Stefan]

User Agent:  

Steps to reproduce:

1. about:config
2. general.useragent.override = "test"
3. Shift-F4


Actual results:

2. Scratchpad opens with work area disabled (greyed out).


Expected results:

2. Ignore UA value.

Bug found in 2011-12-16-03-11-40-mozilla-central (5efcb9c3b375)

Comment 1

[Stefan]

last good 2011-12-14-03-11-34-mozilla-central 221eccfa6a3f
first bad 2011-12-15-03-11-53-mozilla-central beac16509534

Comment 2

[Stefan]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=221eccfa6a3f&tochange=beac16509534

Comment 3

[Alice0775 White]

Regression window(m-c):
Works:
http://hg.mozilla.org/mozilla-central/rev/efab5016434f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111214 Firefox/11.0a1 ID:20111214052826
Fails:
http://hg.mozilla.org/mozilla-central/rev/80bb6b209ea7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111214 Firefox/11.0a1 ID:20111214062919
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=efab5016434f&tochange=80bb6b209ea7


Regression window(fx-team):
Works:
http://hg.mozilla.org/integration/fx-team/rev/a3002672881e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111213 Firefox/11.0a1 ID:20111213040311
fails:
http://hg.mozilla.org/integration/fx-team/rev/ff164dca09bc
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111213 Firefox/11.0a1 ID:20111213055523
Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=a3002672881e&tochange=ff164dca09bc

Suspected:
847e7bead2db	Mihai Sucan — Bug 702331 - Update Orion from upstream; r=rcampbell

Comment 4

[Stefan]

Attachment: experimental patch (hardcoded for Linux)

Comment 5

[Rob Campbell [:rc] (:robcee)]

ah, lovely. Good find.

Mihai, can we do something to prevent Orion from using the system-provided UserAgent string? That could also cause interesting issues if a user's masquerading as another browser, say IE.

Comment 6

[Mihai Sucan [:msucan]]

This was expected.

This is not a regression, it has been like this since we first landed Orion. The manifestation of this problem has probably changed over time.

(In reply to Rob Campbell [:rc] (robcee) from comment #5)
> ah, lovely. Good find.
> 
> Mihai, can we do something to prevent Orion from using the system-provided
> UserAgent string? That could also cause interesting issues if a user's
> masquerading as another browser, say IE.

From SourceEditor we should be able to overwrite window.navigator.platform to make sure that the value from about:config is ignored.

Would this be an acceptable approach?

Comment 7

[Rob Campbell [:rc] (:robcee)]

Moving to Source Editor component.

Filter on CHELICERAE.

Comment 9

[JK]

(In reply to Mihai Sucan [:msucan] from comment #6)
> This was expected.

Isn't user agent sniffing considered deprecated thing that should never be used?

Comment 10

[Mihai Sucan [:msucan]]

(In reply to JK from comment #9)
> (In reply to Mihai Sucan [:msucan] from comment #6)
> > This was expected.
> 
> Isn't user agent sniffing considered deprecated thing that should never be
> used?

Sure, user agent sniffing is not to be used. However, I doubt you can find a big web app that doesn't use it. Feature detection only gets you so far. Workarounds for browser bugs still need to rely on some kind of user agent sniffing. You endup having to know which browser and version your web apps runs in.

Comment 12

[Anton Kovalyov (:anton)]

This is not an issue anymore.