711525 - Remove eBay searchplugin since it is no working anymore

Status: RESOLVED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[Guillermo López :willyaranda (probably SLOW response)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0a1) Gecko/20111216 Firefox/11.0a1
Build ID: 20111216031140

Steps to reproduce:

Ricardo have found that our searchplugin for eBay is not working right now.

The differences between en-US and es-ES are:

willyMacBook:es-ES willyaranda$ diff -u browser/searchplugins/eBay-es.xml ../mozilla-central/browser/locales/en-US/searchplugins/eBay.xml 
--- browser/searchplugins/eBay-es.xml	2011-06-25 22:43:12.000000000 +0200
+++ ../mozilla-central/browser/locales/en-US/searchplugins/eBay.xml	2011-06-23 19:37:00.000000000 +0200
@@ -1,14 +1,15 @@
 <SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
 <ShortName>eBay</ShortName>
-<Description>eBay - Subastas en la red</Description>
+<Description>eBay - Online auctions</Description>
 <InputEncoding>ISO-8859-1</InputEncoding>
 <Image width="16" height="16">data:image/x-icon;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAABFUlEQVQ4jdWTvUoDQRSFvxUfQMFSyBvYpLGSSWFpncY6lsLWFiupBBtLBRsfQcQ2a782PoCkSrONlUGy5LPYn6wbu4DghcOcYs65595hIpVNamsj9V8ajOeFzgsFLmo+LxTXcWJVX8WyppIgKSVPkQQ/F0u3gSFwBfTqdoPoBYDnxRFcDgA4Z4cbPtazqblZptBgxJ2BtGydv+vbkyahSUGC0zxT7VeZ0DguBXFsRs9AKtzq/amOKA2sTAylzMDKoIM6wfXhcWmcBKd51ukeWq8Qx6V0MmFAuppxdx/OIgB6e/32+SoTUGfdHTxy0CRodtF6jZpW2R2qs/alQNrgYTytR8Cf1Rh08VuNGkECJCtd5L//TN/BEWxoE8dlIQAAAABJRU5ErkJggg==</Image>
 <Url type="application/x-suggestions+json" method="GET" template="http://anywhere.ebay.com/services/suggest/">
-   <Param name="s" value="186"/>
-   <Param name="q" value="{searchTerms}"/>
+  <Param name="s" value="0"/>
+  <Param name="q" value="{searchTerms}"/>
 </Url>
-<Url type="text/html" method="GET" template="http://rover.ebay.com/rover/1/1185-104530-33622-0/4">
-   <Param name="mpre" value="mpre=http://shop.ebay.es/?_nkw={searchTerms}"/>
+<Url type="text/html" method="GET" template="http://rover.ebay.com/rover/1/711-47294-18009-3/4">
+  <Param name="mpre" value="http://shop.ebay.com/?_nkw={searchTerms}"/>
 </Url>
-<SearchForm>http://search.ebay.es/</SearchForm>
+<SearchForm>http://search.ebay.com/</SearchForm>
 </SearchPlugin>
+

Should we update the searchplugin to use the new parameters and URLs as in en-US?

Comment 1

[RickieES aka Ricardo Palomares]

Ping Axel, Stas.

The problem with Spanish eBay searchplugin seems to lie in that eBay España main website:

http://www.ebay.es/

acts as an entrance door to two different sites:

http://www.ebay.es/clasico/  and
http://anuncios.ebay.es/

Looking to eBay France and eBay.com, it looks like we should go for the first Spanish URL above:

http://www.ebay.com/
http://www.ebay.fr/
http://www.ebay.es/clasico/

but I'll definitely feel safer if someone from eBay or Mozilla commented on this before providing a patch. Please, note that this issue affects both Firefox and Thunderbird (SeaMonkey is not shipping eBay).

Comment 2

[Axel Hecht [:Pike]]

Kev, do you know what we should do for ebay in spain, or find that out?

Comment 3

[Guillermo López :willyaranda (probably SLOW response)]

Any news here?

Comment 4

[Axel Hecht [:Pike]]

I'm looking at Kev here.

Best way to make sure we're following up is to create a patch with a proposed solution and request review from Kev, so it shows up in queries.

Comment 5

[Guillermo López :willyaranda (probably SLOW response)]

Bugspamming, but this is not working. Should we keep it or just remove it until this get fixed?

Comment 6

[Kev Needham [:kev]]

If it's mine, it's a good idea to assign it to me :D

Will ping folks at eBay today.

Comment 7

[Axel Hecht [:Pike]]

Kev, did you get a pong from the ebay folks?

Comment 8

[Guillermo López :willyaranda (probably SLOW response)]

Kev, do you know something? We are 5 months after this was opened. We are going to remove the plugin from our localization since it's totally useless before the next train leaves.

Comment 9

[RickieES aka Ricardo Palomares]

(In reply to Kev [:kev] Needham from comment #6)
> If it's mine, it's a good idea to assign it to me :D
> 
> Will ping folks at eBay today.


Kev, if they have not answered yet, maybe the time has come to ping them again. :-)

Comment 10

[RickieES aka Ricardo Palomares]

(In reply to Ricardo Palomares from comment #9)
> (In reply to Kev [:kev] Needham from comment #6)
> > If it's mine, it's a good idea to assign it to me :D
> > 
> > Will ping folks at eBay today.
> 
> 
> Kev, if they have not answered yet, maybe the time has come to ping them
> again. :-)


Still waiting for this. Should we think about removing eBay searchplugin?

Comment 11

[Guillermo López :willyaranda (probably SLOW response)]

Ricardo, we should remove it. This is not working yet.

Comment 12

[RickieES aka Ricardo Palomares]

As we haven't got the feedback from eBay we need here for almost 10 months now, I'm ready to request the eBay plugin removal.

L10n drivers, please confirm that we can proceed with the removal so we provide the patch and request the needed review.

Comment 13

[Milos Dinic [:Milos]]

Ricardo, your code is broken, that's why it doesn't work, in particular:

<Param name="mpre" value="mpre=http://shop.ebay.es/?_nkw={searchTerms}"/>

So, there shouldn't be `mpre=` in the parameter value, only search address, everything since http, that is.

Now, I've seen https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=615222&attachment=493687 which was added by Kev, and I assume he got it from eBay. Now, what I'm not really sure about is whether we can just fix errors, even if so obvious, or do we need a permission from eBay, but let's have Axel or Kev answer that.

Comment 14

[RickieES aka Ricardo Palomares]

(In reply to Milos Dinic [:Milos] from comment #13)
> Ricardo, your code is broken, that's why it doesn't work, in particular:
> 
> <Param name="mpre" value="mpre=http://shop.ebay.es/?_nkw={searchTerms}"/>
> 
> So, there shouldn't be `mpre=` in the parameter value, only search address,
> everything since http, that is.


OK, sorry, so the error landed in:

http://hg.mozilla.org/l10n-central/es-ES/rev/123ea416f3ad

which was replicating changes in en-US tracked in:

http://hg.mozilla.org/mozilla-central/rev/837cbbef3695

I've removed locally the offending "mpre=" and, of course, it now works right.

Ironically, it seems this parameter was added to implement search suggestions, and I can't yet get anything (useful). But, maybe, as commented in bug 615222, the suggested search terms feature was not active at the time the patch was applied and thus it didn't break the searchplugin.

Comment 15

[Axel Hecht [:Pike]]

Can't really say, Kev?

Comment 16

[RickieES aka Ricardo Palomares]

(In reply to Axel Hecht [:Pike] from comment #15)
> Can't really say, Kev?

So, as Kev hasn't say anything yet, can we prepare a patch to fix this per comment #14 and move this bug forward?

Comment 17

[Carsten Book [:Tomcat]]

(In reply to Ricardo Palomares from comment #16)
> (In reply to Axel Hecht [:Pike] from comment #15)
> > Can't really say, Kev?
> 
> So, as Kev hasn't say anything yet, can we prepare a patch to fix this per
> comment #14 and move this bug forward?

adding joanne here.

Comment 18

[Kev Needham [:kev]]

Will work with Joanne on this and get a new string for uplift into 22.

Comment 19

[RickieES aka Ricardo Palomares]

Attachment: Patch removing alien content in value param

In the end, it seems this is just a regular p12n bug in es-ES, so I'm providing a patch to fix it.

Comment 20

[Axel Hecht [:Pike]]

Comment on attachment 760104 [details] [diff] [review]
Patch removing alien content in value param

Review of attachment 760104 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this is just a technical fix, r=me.

Usual dance, please land with a comment referencing this bug and my comment.

That said, I think it's late to take this fix on beta unless we get a request otherwise. So just aurora and central, I'd say.

Comment 21

[RickieES aka Ricardo Palomares]

Done:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-ES/rev/e48ac79153cd
http://hg.mozilla.org/l10n-central/es-ES/rev/87371e8203c6

Now waiting for builds to test and sign-off.

Thank you.