Open
Bug 711527
Opened 13 years ago
Updated 2 years ago
Should error when missing profiling data for libxul in Windows PGO builds
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
NEW
People
(Reporter: ted, Unassigned)
References
Details
In bug 711478 we discovered that a change had broken PGO builds in a way that made them get linked without any profiling data (so not really PGO optimized). Unfortunately this doesn't have any visible effects (except probably on Talos) unless you really scrutinize the logs. We should just error if the profiling data is missing when we go to re-link libxul the last time. I'm thinking of adding something like export MOZ_PROFILE_DATA_REQUIRED = 1 to toolkit/library/Makefile.in, and then pgomerge.py can error if that's set and it doesn't find any profile data: http://mxr.mozilla.org/mozilla-central/source/build/win32/pgomerge.py
Updated•6 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•