711628 - Implement MediaStreamArray class for PeerConnection's localStreams/remoteStreams

Status: VERIFIED FIXED

(Core :: WebRTC, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Per discussion in #content, use a scriptableHelper, and then make MediaStreamArray to provide the localStreams/remoteStreams arrays required by the webidl (which says they have to be 'live').  

	bholley	jesup: I _think_ you can get away with subclassing nsArraySH, rather than nsGenericArraySH, and just implementing GetItemAt
                See also https://developer.mozilla.org/en/Mozilla_DOM_Hacking_Guide

In the much longer future, bug 580070 should provide easier ways to do this, but that's much further out.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP patch to add MediaStreamList's and use them in IDL

This is a work-in-progress, and note the naming of nsWebRTCMediaStream.h is to avoid nsMediaStream.h in content; the name will change before checkin (or roc's changes for mediastreams will land and I'll be able to remove my mediastream stub).

However, this should show how I'm planning to implement the "live array return" using nsArraySH, as recommended.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 582905 [details] [diff] [review]
WIP patch to add MediaStreamList's and use them in IDL

I realize this is incomplete and rough, but I figured I'd run it past you while it's still relatively fresh in your minds.  Did I miss/forget anything obvious?

(yes, I know I need to vet the license boilerplates - they were just copied largely from the code I Cargo-Culted off of.)

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 582905 [details] [diff] [review]
WIP patch to add MediaStreamList's and use them in IDL

This generally looks like the right approach.

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v1

Boris, could you take a look at the binding stuff?

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Note to bz - this probably applies against Alder, as PeerConnection/etc aren't on m-c yet.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 661340 [details] [diff] [review]
v1

>+++ b/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp
>+  return mLocalSourceStreams[index].get();

Why do you need the .get()?

>+  return mRemoteSourceStreams[index].get();

Likewise.

r=me

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

What's left to do here on the bug Peter? Can we finalize the patch and get it landed. It contains some parts we really would like to have for our first Mochitests for WebRTC. Thanks!

Comment 8

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7019f73a5f0

Comment 9

[Ed Morley [:emorley]]

Push backed out for compilation failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2dbcd6d16b43

https://hg.mozilla.org/integration/mozilla-inbound/rev/5540b310d435

Comment 10

[Daniel Holbert [:dholbert]]

Well after the backout, we got a build failure relating to one of the files added by this bug's patch:
 https://tbpl.mozilla.org/php/getParsedLog.php?id=16047049&tree=Mozilla-Inbound
 make[7]: *** No rule to make target `src/peerconnection/MediaStreamList.cpp', needed by `src/peerconnection/MediaStreamList.o'.  Stop.

Looks like this requires a clobber to clean up after a backout, or something (?)

Comment 11

[Peter Van der Beken [:peterv]]

(In reply to Daniel Holbert [:dholbert] from comment #10)
> Looks like this requires a clobber to clean up after a backout, or something

I think that was bug 800847.

Relanded with the interface in a MOZ_WEBRTC condition.

http://hg.mozilla.org/integration/mozilla-inbound/rev/bbcf489988a4

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bbcf489988a4

Comment 13

[Jason Smith [:jsmith]]

Validated through automation and a couple of manual sanity checks.