711655 - Make "reply" js function more intelligent

Status: REOPENED

(Bugzilla :: User Interface, enhancement)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Maybe I don't work linearly all the time, but often when I click on 'reply', I actually want the 'in reply to...' stuff to go where the caret is in the comment textarea, not at the end - I'll start replying or just commenting & realize I actually want to reply to a previous comment, so I press reply only to have it added at the end.

While we're at it, we could do some whitespace detection so that the previous comment is always padded with newlines.

Comment 1

[Anamika_07]

Attachment: UI_Patch

Comment 2

[Anamika_07]

Attachment: UI_PATCH

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8797608 [details] [diff] [review]
UI_PATCH

Review of attachment 8797608 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Comment 4

[Dylan Hardison [:dylan] (he/him)]

To github.com:bugzilla/bugzilla.git
   d9ba51c..b0f5a16  master -> master

Comment 5

[Frédéric Buclin]

Errr... this fix doesn't do what it's supposed to do. Now when you click on the "reply" link, the new text is always put at the beginning of the textarea, not at the position of the caret. So if I leave the caret at the end of the textarea (because I work linearly), the new text is no longer put at the end of the textarea.

Please backout this patch.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

(In reply to Frédéric Buclin from comment #5)
> Errr... this fix doesn't do what it's supposed to do. Now when you click on
> the "reply" link, the new text is always put at the beginning of the
> textarea, not at the position of the caret. So if I leave the caret at the
> end of the textarea (because I work linearly), the new text is no longer put
> at the end of the textarea.
> 
> Please backout this patch.

I find the existing behavior to be counter-intuitive, but I'll consider it.

Comment 7

[Dylan Hardison [:dylan] (he/him)]

Reverted

To github.com:bugzilla/bugzilla.git
   f1b9ed5..c4a1ca8  master -> master