If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Make "reply" js function more intelligent

REOPENED
Unassigned

Status

()

Bugzilla
User Interface
--
enhancement
REOPENED
6 years ago
a year ago

People

(Reporter: zpao, Unassigned)

Tracking

Details

Attachments

(2 obsolete attachments)

Maybe I don't work linearly all the time, but often when I click on 'reply', I actually want the 'in reply to...' stuff to go where the caret is in the comment textarea, not at the end - I'll start replying or just commenting & realize I actually want to reply to a previous comment, so I press reply only to have it added at the end.

While we're at it, we could do some whitespace detection so that the previous comment is always padded with newlines.

Updated

6 years ago
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → 4.0.2

Comment 1

a year ago
Created attachment 8797271 [details] [diff] [review]
UI_Patch
Attachment #8797271 - Flags: review?(dylan)

Comment 2

a year ago
Created attachment 8797608 [details] [diff] [review]
UI_PATCH
Attachment #8797271 - Attachment is obsolete: true
Attachment #8797271 - Flags: review?(dylan)
Attachment #8797608 - Flags: review?(dylan)
Comment on attachment 8797608 [details] [diff] [review]
UI_PATCH

Review of attachment 8797608 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8797608 - Flags: review?(dylan) → review+
Assignee: ui → h2014313059
To github.com:bugzilla/bugzilla.git
   d9ba51c..b0f5a16  master -> master
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED

Comment 5

a year ago
Errr... this fix doesn't do what it's supposed to do. Now when you click on the "reply" link, the new text is always put at the beginning of the textarea, not at the position of the caret. So if I leave the caret at the end of the textarea (because I work linearly), the new text is no longer put at the end of the textarea.

Please backout this patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Frédéric Buclin from comment #5)
> Errr... this fix doesn't do what it's supposed to do. Now when you click on
> the "reply" link, the new text is always put at the beginning of the
> textarea, not at the position of the caret. So if I leave the caret at the
> end of the textarea (because I work linearly), the new text is no longer put
> at the end of the textarea.
> 
> Please backout this patch.

I find the existing behavior to be counter-intuitive, but I'll consider it.
Summary: 'reply' JS should insert at caret position → Make "reply" js function more intelligent
Reverted

To github.com:bugzilla/bugzilla.git
   f1b9ed5..c4a1ca8  master -> master
Assignee: h2014313059 → ui
Attachment #8797608 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.