711660 - maintenance service updater tests can't be run locally

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

Though the tests do run via buildbot, we need to come up with a way to run updater tests locally. At present, there are several steps that have to be performed manually.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

KEY_WOW64_64KEY is not defined in nsWindowsRegKey so I just defined it in the JavaScript. I want to check out whether these tests are going to run on non Firefox before asking for review.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Only a slight change in that I don't think it is appropriate to check all the way down to the 0 key since the keys are enumerated.

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 582438 [details] [diff] [review]
patch rev2

Review of attachment 582438 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this, looks great.
Minor nit.

::: toolkit/mozapps/update/test/unit/head_update.js.in
@@ +460,5 @@
> + */
> +function shouldRunServiceTest() {
> +  const REG_PATH = "SOFTWARE\\Mozilla\\MaintenanceService\\" +
> +                   "3932ecacee736d366d6436db0f55bce4";
> +  const KEY_WOW64_64KEY = 256;

nit: You can use key.WOW64_64 which was added to that interface as part of bug 481815 instead.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev3

Also added to the function comment
* @return true if the test should run and false if it shouldn't.

Carrying forward r+

Comment 5

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/mozilla-central/rev/8401a8217e98