maintenance service updater tests can't be run locally

RESOLVED FIXED in mozilla12

Status

()

Toolkit
Application Update
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Trunk
mozilla12
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Though the tests do run via buildbot, we need to come up with a way to run updater tests locally. At present, there are several steps that have to be performed manually.
Created attachment 582436 [details] [diff] [review]
patch rev1

KEY_WOW64_64KEY is not defined in nsWindowsRegKey so I just defined it in the JavaScript. I want to check out whether these tests are going to run on non Firefox before asking for review.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #582436 - Flags: review?(netzen)
Created attachment 582438 [details] [diff] [review]
patch rev2

Only a slight change in that I don't think it is appropriate to check all the way down to the 0 key since the keys are enumerated.
Attachment #582436 - Attachment is obsolete: true
Attachment #582436 - Flags: review?(netzen)
Attachment #582438 - Flags: review?(netzen)
Comment on attachment 582438 [details] [diff] [review]
patch rev2

Review of attachment 582438 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this, looks great.
Minor nit.

::: toolkit/mozapps/update/test/unit/head_update.js.in
@@ +460,5 @@
> + */
> +function shouldRunServiceTest() {
> +  const REG_PATH = "SOFTWARE\\Mozilla\\MaintenanceService\\" +
> +                   "3932ecacee736d366d6436db0f55bce4";
> +  const KEY_WOW64_64KEY = 256;

nit: You can use key.WOW64_64 which was added to that interface as part of bug 481815 instead.
Attachment #582438 - Flags: review?(netzen) → review+
Created attachment 582442 [details] [diff] [review]
patch rev3

Also added to the function comment
* @return true if the test should run and false if it shouldn't.

Carrying forward r+
Attachment #582438 - Attachment is obsolete: true
Attachment #582442 - Flags: review+
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.