Closed Bug 711671 Opened 8 years ago Closed 8 years ago

Rename nsTelephonyWorker / nsITelephone to nsIRadioInterfaceLayer


(Core :: DOM: Device Interfaces, defect)

Gonk (Firefox OS)
Not set





(Reporter: philikon, Assigned: philikon)




(1 file, 2 obsolete files)

nsITelephone / nsTelephonyWorker is somewhat of a misnomer. First, it's not a worker itself, it just talks to a worker and exposes it (via nsIRadioWorker). Functionality-wise, it does more than just calls (SMS, data calls, network status -- we're in the process of adding all these now). API-wise it doesn't really provide much abstraction over the RIL, it's merely glue between the worker and the DOM.

So let's call it what it is: the RadioInterfaceLayer.
Oh, and all the RIL-stuff (nsIRadioInterfaceLayer, the RadioInterfaceLayer.js component, and ril_worker.js) should also move to from dom/telephony to dom/system/b2g IMHO (see above argument about not just being about telephony anymore).
Attached patch Patch, v1 (obsolete) — Splinter Review
Here's a stab at making this better. It's now SystemWorkerManager, since it will manage workers that are owned by system components. This also uses the GetInterface stuff that mrbkap and I have discussed in the past.

We can bikeshed more on the name later, but this is the interface we want I think. Comments and disagreements welcome (always).
Assignee: philipp → bent.mozilla
Attachment #585122 - Flags: review?(mrbkap)
Comment on attachment 585122 [details] [diff] [review]
Patch, v1

First off, having skimmed it only briefly, I agree with this patch! But this isn't quite what I had in mind for this bug. I thought the bug summary was kinda clear, but I guess it wasn't. (Way to hijack my bug, bent! :p)

I'm happy to consider this patch part 1 and do the nsITelephone -> nsIRadioInterfaceLayer renaming in part 2 (which I'm happy to write.)
Comment on attachment 585122 [details] [diff] [review]
Patch, v1

Oops. It was late and I didn't really read the bug, was just looking for 'rename' in the summary. You're right, this isn't the bug I want.
Attachment #585122 - Flags: review?(mrbkap)
Assignee: bent.mozilla → philipp
Comment on attachment 585122 [details] [diff] [review]
Patch, v1

This stuff landed in the other bug.
Attachment #585122 - Attachment is obsolete: true
Attached patch v1 (obsolete) — Splinter Review
Completely mechanical rename of the interfaces and relocation of RIL-specific stuff to dom/system/b2g, as discussed in previous comments.
Attachment #589712 - Flags: review?(bent.mozilla)
Attached patch v2Splinter Review
Forgot to qrefresh... This version of the patch actually compiles ;)
Attachment #589712 - Attachment is obsolete: true
Attachment #589712 - Flags: review?(bent.mozilla)
Attachment #589758 - Flags: review?(bent.mozilla)
Attachment #589758 - Flags: review?(bent.mozilla) → review+
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Depends on: 720601
You need to log in before you can comment on or make changes to this bug.