Closed
Bug 711704
Opened 13 years ago
Closed 13 years ago
trailing comma in nsXULTooltipListener.h
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: kdevel, Assigned: kdevel)
Details
(Whiteboard: [fixed by bug 711908 and others in comment 2])
Attachments
(1 file, 1 obsolete file)
|
942 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
User Agent: Build ID: 20111216200736 Steps to reproduce: 1. Compile source with OpenSUSE Evergreen 11.1 GCC (cf. Bug 706610) Actual results: 1. Three new errors are reported. Expected results: 1. No errors (fix attached).
Both are fixed now: - No bug - Remove stray semicolons from FILEINFO_SUBCLASS calls, the macro already includes it; rs=jfkthame http://hg.mozilla.org/mozilla-central/rev/543af61eee05 - No bug - Remove stray semicolon in nsThread.cpp; rs=bsmedberg http://hg.mozilla.org/mozilla-central/rev/f6adee33fc61
Doesn't look like those 2 commits cover all fixes in your patch. Only the nsThread.cpp case is covered. Or what do you mean?
Oops. Actually the excess comma in nsXULTooltipListener.h has not been removed. 543af61eee05 fixes the Problem in Fileinfo.h keeping the semicolon in the #define and removing it where the define is used. I fixed it the other way around.
So can you update the patch to contain only the nsXULTooltipListener.h part and then request review?
Status: UNCONFIRMED → NEW
Component: General → XUL
Ever confirmed: true
Product: Firefox → Core
QA Contact: general → xptoolkit.widgets
Assignee: nobody → kdevel
Status: NEW → ASSIGNED
OS: Other → Linux
Summary: trailing comma, trailing semicolon → trailing comma in nsXULTooltipListener.h
Attachment #582504 -
Attachment is obsolete: true
Attachment #583235 -
Flags: review?(bzbarsky)
|
||
Comment 7•13 years ago
|
||
Comment on attachment 583235 [details] [diff] [review] fix v2 r=me
Attachment #583235 -
Flags: review?(bzbarsky) → review+
fixed in Bug 711908 - Fix a bunch of GCC warnings in layout with https://hg.mozilla.org/mozilla-central/rev/1e25bdfb62c0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 711908 and others in comment 2]
You need to log in
before you can comment on or make changes to this bug.
Description
•