trailing comma in nsXULTooltipListener.h

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Stefan, Assigned: Stefan)

Tracking

Trunk
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed by bug 711908 and others in comment 2])

Attachments

(1 attachment, 1 obsolete attachment)

942 bytes, patch
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
User Agent:  
Build ID: 20111216200736

Steps to reproduce:

1. Compile source with OpenSUSE Evergreen 11.1 GCC (cf. Bug 706610)


Actual results:

1. Three new errors are reported.


Expected results:

1. No errors (fix attached).
(Assignee)

Comment 1

6 years ago
Created attachment 582504 [details] [diff] [review]
fix
(Assignee)

Comment 2

6 years ago
Both are fixed now:

- No bug - Remove stray semicolons from FILEINFO_SUBCLASS calls, the macro already
  includes it; rs=jfkthame 
  http://hg.mozilla.org/mozilla-central/rev/543af61eee05

- No bug - Remove stray semicolon in nsThread.cpp; rs=bsmedberg 
  http://hg.mozilla.org/mozilla-central/rev/f6adee33fc61

Comment 3

6 years ago
Doesn't look like those 2 commits cover all fixes in your patch.
Only the nsThread.cpp case is covered.

Or what do you mean?
(Assignee)

Comment 4

6 years ago
Oops. Actually the excess comma in nsXULTooltipListener.h has not been removed.

543af61eee05 fixes the Problem in Fileinfo.h keeping the semicolon in the #define and removing it where the define is used. I fixed it the other way around.

Comment 5

6 years ago
So can you update the patch to contain only the nsXULTooltipListener.h part and then request review?
Status: UNCONFIRMED → NEW
Component: General → XUL
Ever confirmed: true
Product: Firefox → Core
QA Contact: general → xptoolkit.widgets

Updated

6 years ago
Assignee: nobody → kdevel
Status: NEW → ASSIGNED
OS: Other → Linux
Summary: trailing comma, trailing semicolon → trailing comma in nsXULTooltipListener.h
(Assignee)

Comment 6

6 years ago
Created attachment 583235 [details] [diff] [review]
fix v2
Attachment #582504 - Attachment is obsolete: true

Updated

6 years ago
Attachment #583235 - Flags: review?(bzbarsky)
Comment on attachment 583235 [details] [diff] [review]
fix v2

r=me
Attachment #583235 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 8

6 years ago
fixed in 
Bug 711908 - Fix a bunch of GCC warnings in layout
with
https://hg.mozilla.org/mozilla-central/rev/1e25bdfb62c0

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 711908 and others in comment 2]
You need to log in before you can comment on or make changes to this bug.