711717 - Expose manifest errors during app installation

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

https://myapps.mozillalabs.com/getmanifest was timing out, as a result it was taking up to 1 min to show "couldn't retrieve application manifest from network" errors. Upon subsequent attempts I was getting "502 Bad Gateway" errors. If we can't verify the manifest fast enough, we show first indicate status (perhaps by adding a loading throbber near the "Install App" button) and throw an error as soon as possible. As is, app installation just looks broken.

Comment 1

[Wil Clouser [:clouserw]]

Sounds good.  Potch is redoing these now in bug 734435

Comment 3

[Christopher Van Wiemeersch [:cvan]]

We used to handle many error cases (https://github.com/mozilla/zamboni/blob/master/./media/js/zamboni/apps.js#L48) but now we don't (https://github.com/mozilla/zamboni/blob/master/./media/js/mkt/apps.js). This bug is to expose those errors.

Comment 4

[Kumar McMillan [:kumar]]

this might be a good opportunity to activate JS tests for mkt. Having tests to cover our navigator.mozApps abstraction is really important, especially for error handling. These were the amo tests that can be copied over: https://github.com/mozilla/zamboni/blob/master/media/js/zamboni/tests/apps_tests.js

Comment 5

[Davor Spasovski [:spasovski]]

done: https://github.com/mozilla/zamboni/commit/f947955

@kumar: I will have to address the tests after Apr. 26th since they may need a slight rework (new error codes and no existing qunit tests).

Comment 6

[krupa raj[:krupa]]

Let us show more details about validation failures. http://cl.ly/1A1L032d3W0C0P0m1M0H is not very useful. Thanks!

Comment 7

[Kumar McMillan [:kumar]]

We don't have access to more detailed errors - you'd have to open a bug in WebRT; we are displaying the values returned by the mozApps.install() function. Our translations are here: https://github.com/mozilla/zamboni/commit/f947955#L2R45