711726 - Race condition in service tests causing intermittent failures

Status: RESOLVED INVALID

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

We currently set some environment variables that are used by the application which starts the update, then we call the application which starts the update async, then we immediately reset the env variables.  Race condition in the test.

The application which starts the update needs these env variables defined.  Sometimes they will exist, sometimes they will not exist, depending on if the app that was launched gets to them or not fast enough.

The env vars in question are: MOZ_UPDATE_ROOT_OVERRIDE and MOZ_UPDATE_APPDIR_OVERRIDE

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

Comment 2

[Brian R. Bondy [:bbondy]]

I think this might not be valid because I think the process gets a copy of the env variables when it starts.  I might mark this as invalid or change the subject to reflect whatever the problem is causing elm to hang on the first test. 

I'm not sure yet why the elm build is failing but the patch above doesn't seem to fix it.

Comment 3

[Brian R. Bondy [:bbondy]]

Note: win debug consistently passes... 
https://tbpl.mozilla.org/?tree=Elm

Comment 4

[Robert Strong (they/them - no direct email)]

I don't think this bug is valid and would very much prefer to keep this async

Comment 5

[Brian R. Bondy [:bbondy]]

agree this is not our bug. I have a release build going now which I'll try to reproduce the problem with.