711753 - [ICS] - Crash reporter button labels are unreadable in landscape mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Mike Hommey [:glandium]]

Attachment: Screenshot

Might be ICS specific. See attached screenshot.

Comment 1

[Sriram Ramasubramanian [:sriram]]

The shrinking of the button is as a result of "ActionBar" added on top by the ICS. I have a fix ready. But I would to know how to get the CrashReporter.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #1)
> The shrinking of the button is as a result of "ActionBar" added on top by
> the ICS. I have a fix ready. But I would to know how to get the
> CrashReporter.

Sounds like you need a way to make the crash reporter open?

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Enclosed everything in a ScrollView and works as expected.

Comment 4

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/51839400b331

Comment 5

[Jonathan Kew [:jfkthame]]

This turned native android builds red, so I backed it out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d1523c2efcd

Example log: https://tbpl.mozilla.org/php/getParsedLog.php?id=10100507&tree=Mozilla-Inbound
....
res/layout/crash_reporter.xml:6: error: Error parsing XML: duplicate attribute
make[6]: *** [R.java] Error 1
make[6]: Leaving directory `/builds/slave/m-in-andrd-dbg/build/obj-firefox/mobile/android/base'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/builds/slave/m-in-andrd-dbg/build/obj-firefox/mobile/android'
make[4]: *** [libs_tier_app] Error 2
make[4]: Leaving directory `/builds/slave/m-in-andrd-dbg/build/obj-firefox'
make[3]: *** [tier_app] Error 2
make[3]: Leaving directory `/builds/slave/m-in-andrd-dbg/build/obj-firefox'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/builds/slave/m-in-andrd-dbg/build/obj-firefox'
make[1]: *** [realbuild] Error 2
make[1]: Leaving directory `/builds/slave/m-in-andrd-dbg/build'
make: *** [build] Error 2
program finished with exit code 2

Comment 6

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/25443615932d

That has been fixed in this patch.

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/51839400b331

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/25443615932d

Comment 9

[Cristian Nicolae (:xti)]

No longer occurs in the latest Nightly. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-21)
Device: Galaxy Nexus
OS: Android 4.0.2

Comment 10

[Robert Kaiser]

On my tablet, the buttons are now OK, but the rest of the text is bad, see bug 836356