Zombie compartment with Adblock Plus Pop-up Addon 0.2.9 after clicking on a link

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Loic, Unassigned)

Tracking

(Blocks: 1 bug)

8 Branch
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P3])

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111104165243

Steps to reproduce:

Adblock Plus Pop-up Addon is an add-on of Adblock Plus to extend its blocking functionality to pop-up windows and pop-up tabs.
See http://jessehakanen.net/adblockpluspopupaddon/ for more details.

STR:
1) Create a new profile with Firefox
2) Install Adblock Plus Pop-up Addon 0.2.9 (https://addons.mozilla.org/firefox/addon/adblock-plus-pop-up-addon/).
NB: You can install Adblock Plus or not, it doesn't matter.
3) Open http://forum.hardware.fr/hfr/gsmgpspda/smartphone/unique-motorola-froyo-sujet_22113_69.htm#t875683 (message of a French board)
4) Click on the link under the name "Jacques Glassman" (inside the message) to open http://www.liberation.fr/cahier-special/0101291379-jacques-glassman-le-footballeur-qui-a-denonce-le-scandale-va-om-tente-de-reconstruire-sa-vie
5) Open about:memory?verbose in another tab
6) Close the 1st tab and the 2nd tab
7) Return to about:memory?verbose, hit the "minimize memory usage" button few times and wait for 10-15 min.


Actual results:

compartment(http://www.liberation.fr/cahier-special/0101291379-jacques-glassman-le-footballeur-qui-a-denonce-le-scandale-va-om-tente-de-reconstruire-sa-vie) stays alive as zombie compartment.


Expected results:

This compartment should be closed normally as in safe mode.
You can test with Nightly 11.0a1, same result.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0

│  ├───2,450,838 B (03.01%) -- compartment(http://www.liberation.fr/cahier-special/0101291379-jacques-glassman-le-footballeur-qui-a-denonce-le-scandale-va-om-tente-de-reconstruire-sa-vie)
│  │   ├──1,134,592 B (01.39%) -- gc-heap
│  │   │  ├────570,536 B (00.70%) -- arena-unused
│  │   │  ├────316,496 B (00.39%) -- objects
│  │   │  ├────232,000 B (00.29%) -- shapes
│  │   │  ├──────7,504 B (00.01%) -- strings
│  │   │  ├──────4,432 B (00.01%) -- arena-headers
│  │   │  └──────3,624 B (00.00%) -- arena-padding
│  │   ├────458,752 B (00.56%) -- mjit-code
│  │   ├────361,364 B (00.44%) -- scripts
│  │   ├────200,624 B (00.25%) -- tjit-data
│  │   │    ├───97,392 B (00.12%) -- trace-monitor
│  │   │    ├───74,000 B (00.09%) -- allocators-reserve
│  │   │    └───29,232 B (00.04%) -- allocators-main
│  │   ├────131,072 B (00.16%) -- tjit-code
│  │   ├─────96,368 B (00.12%) -- property-tables
│  │   ├─────44,944 B (00.06%) -- object-slots
│  │   └─────23,122 B (00.03%) -- string-chars

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111216 Firefox/11.0a1

│  ├───1,960,712 B (03.10%) -- compartment(http://www.liberation.fr/cahier-special/0101291379-jacques-glassman-le-footballeur-qui-a-denonce-le-scandale-va-om-tente-de-reconstruire-sa-vie)
│  │   ├──1,036,288 B (01.64%) -- gc-heap
│  │   │  ├────517,880 B (00.82%) -- arena
│  │   │  │    ├──512,216 B (00.81%) -- unused
│  │   │  │    ├────4,048 B (00.01%) -- headers
│  │   │  │    └────1,616 B (00.00%) -- padding
│  │   │  ├────168,064 B (00.27%) -- objects
│  │   │  │    ├───88,640 B (00.14%) -- function
│  │   │  │    └───79,424 B (00.13%) -- non-function
│  │   │  ├────157,864 B (00.25%) -- shapes
│  │   │  │    ├───93,432 B (00.15%) -- tree
│  │   │  │    ├───48,816 B (00.08%) -- dict
│  │   │  │    └───15,616 B (00.02%) -- base
│  │   │  ├────146,608 B (00.23%) -- scripts
│  │   │  ├─────42,336 B (00.07%) -- type-objects
│  │   │  └──────3,536 B (00.01%) -- strings
│  │   ├────327,680 B (00.52%) -- mjit-code
│  │   ├────280,504 B (00.44%) -- script-data
│  │   ├────107,232 B (00.17%) -- shapes-extra
│  │   │    ├───52,128 B (00.08%) -- tree-tables
│  │   │    ├───22,112 B (00.03%) -- dict-tables
│  │   │    ├───20,128 B (00.03%) -- tree-shape-kids
│  │   │    └───12,864 B (00.02%) -- compartment-tables
│  │   ├────105,264 B (00.17%) -- analysis-temporary
│  │   ├─────52,192 B (00.08%) -- object-slots
│  │   ├─────35,440 B (00.06%) -- type-inference
│  │   │     ├──25,840 B (00.04%) -- object-main
│  │   │     └───9,600 B (00.02%) -- tables
│  │   └─────16,112 B (00.03%) -- string-chars
(Reporter)

Updated

6 years ago
Blocks: 668871, 700547
Component: General → JavaScript Engine
Product: Firefox → Core
Whiteboard: [MemShrink]
(Reporter)

Comment 1

6 years ago
Created attachment 582600 [details]
about_memory_ff8.0
(Reporter)

Comment 2

6 years ago
Created attachment 582601 [details]
about_memory_ff11a1
Wladimir, do you know if Jesse Hakanen is on Bugzilla?  I'd like to CC him here.
Whiteboard: [MemShrink] → [MemShrink:P3]
(Reporter)

Comment 4

6 years ago
He's not. I added his email (see http://jessehakanen.net/adblockpluspopupaddon/#contact ) to CC list but Bugzilla sent me an error message.

But, I emailed him about this bug yesterday, here his reply:

> I already fixed these zombie compartments in Firefox 5, but now they
> are indeed back again in 8 and newer versions. Seems that the window
> opening process had changed a bit, which is why Adblock Plus Pop-up
> Addon didn't catch the unload event for tabs. Therefore some
> references to closed tabs were left in memory.
>
> The next version of Adblock Plus Pop-up Addon will fix the issue.
Thanks, Loic!

Let's keep this open until someone can confirm.
(Reporter)

Comment 6

6 years ago
Adblock Plus Pop-up Addon 0.3 has been released, see https://addons.mozilla.org/fr/firefox/addon/adblock-plus-pop-up-addon/

Changelog:
* Fixed a memory leak which appeared in Firefox 8+

I tested with v0.3 and I wasn't able to reproducce the STR I gave in comment #0 so I assume the bug has been fixed. Thanks to Jesse Hakanen.
Loic:  were you able to reproduce the problem with the version prior to v0.3?  If so, we can close this bug.
(Reporter)

Comment 8

6 years ago
Yes, tested STR with FF9.0.1/FF12:
* Adblock Plus Pop-up Addon 0.2.9 (flagged now as incompatible with FF9+ but forced with Add-on Compatibility Reporter): zombie compartment
* Update to Adblock Plus Pop-up Addon 0.3: no zombie compartment

So according to my STR, the bug has been fixed with the new add-on version 0.3.
Thanks for the extra info, Loic.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.