Closed Bug 711790 Opened 13 years ago Closed 10 years ago

Remove remnants of intl/chardet

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smontagu, Assigned: smontagu)

References

Details

Most of intl/chardet was removed in bug 426271. What remains can probably also be removed. (see bug 710980 comment 6).
Depends on: 655255
Depends on: 713825
Depends on: 713866
Depends on: 683429
Depends on: 726950
Should we always use universalchardet? (removing the --disable-universalchardet option)
I'm not totally sure what you're asking. If you want charset detection at all, you shouldn't use --disable-universalchardet, because most of the options for charset detection are only available via universalchardet.
(In reply to Simon Montagu from comment #2)
> I'm not totally sure what you're asking. If you want charset detection at
> all, you shouldn't use --disable-universalchardet, because most of the
> options for charset detection are only available via universalchardet.

If I understand correctly, we build intl/chardet regardless of any option and universalchardet only if it isn't disabled.
Does this bug include always enabling universalchardet removing the "--disable-universalchardet" option?
OK, in that case --disable-universalchardet makes no sense and should be removed.
MOZ_UNIVERSALCHARDET is used in toolkit/toolkit.mozbuild to decide whether extensions/universalchardet/ is built. So --disable-universalchardet does have an effect. Whether it's useful to be able to disable this feature is another question, and one whose answer I don't know.
Can this bug be considered fixed now?
All dependent bugs are closed.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.