711790 - Remove remnants of intl/chardet

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Simon Montagu :smontagu]

Most of intl/chardet was removed in bug 426271. What remains can probably also be removed. (see bug 710980 comment 6).

Comment 1

[Marco Castelluccio [:marco]]

Should we always use universalchardet? (removing the --disable-universalchardet option)

Comment 2

[Simon Montagu :smontagu]

I'm not totally sure what you're asking. If you want charset detection at all, you shouldn't use --disable-universalchardet, because most of the options for charset detection are only available via universalchardet.

Comment 3

[Marco Castelluccio [:marco]]

(In reply to Simon Montagu from comment #2)
> I'm not totally sure what you're asking. If you want charset detection at
> all, you shouldn't use --disable-universalchardet, because most of the
> options for charset detection are only available via universalchardet.

If I understand correctly, we build intl/chardet regardless of any option and universalchardet only if it isn't disabled.
Does this bug include always enabling universalchardet removing the "--disable-universalchardet" option?

Comment 4

[Simon Montagu :smontagu]

OK, in that case --disable-universalchardet makes no sense and should be removed.

Comment 5

[Nicholas Nethercote [inactive]]

MOZ_UNIVERSALCHARDET is used in toolkit/toolkit.mozbuild to decide whether extensions/universalchardet/ is built. So --disable-universalchardet does have an effect. Whether it's useful to be able to disable this feature is another question, and one whose answer I don't know.

Comment 6

[Florian Bender]

Can this bug be considered fixed now?

Comment 7

[Masatoshi Kimura [:emk]]

All dependent bugs are closed.