Last Comment Bug 711867 - Track dirty region in gonk widget backend
: Track dirty region in gonk widget backend
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla12
Assigned To: Michael Wu [:mwu]
:
Mentors:
Depends on:
Blocks: 708524 714307
  Show dependency treegraph
 
Reported: 2011-12-18 13:37 PST by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2011-12-30 12:47 PST (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Track dirty region (1.25 KB, patch)
2011-12-29 14:14 PST, Michael Wu [:mwu]
no flags Details | Diff | Review
Track dirty region, v2 (1.33 KB, patch)
2011-12-29 14:28 PST, Michael Wu [:mwu]
cjones.bugs: review+
Details | Diff | Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-18 13:37:42 PST
See bug 708524.

There's an implementation of this for PuppetWidget.cpp that can be copied.  I'm not sure if it's worth sharing that impl yet.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-18 13:39:31 PST
Bug 708524 comment 25.
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-19 07:35:23 PST
Mike, can you take this?  This is pretty high priority; it's blocking measuring and fixing perf issues in b2g-gonk.
Comment 3 Michael Wu [:mwu] 2011-12-29 14:14:41 PST
Created attachment 584850 [details] [diff] [review]
Track dirty region

This also adds support for sync invalidation since we're already in here fixing this function.
Comment 4 Michael Wu [:mwu] 2011-12-29 14:16:06 PST
Comment on attachment 584850 [details] [diff] [review]
Track dirty region

Uh, screwed something up, lemme upload a new patch.
Comment 5 Michael Wu [:mwu] 2011-12-29 14:28:59 PST
Created attachment 584855 [details] [diff] [review]
Track dirty region, v2
Comment 6 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-29 14:56:18 PST
Comment on attachment 584855 [details] [diff] [review]
Track dirty region, v2

Let's get this landed asap.  Will you be able to today?
Comment 8 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-12-30 04:55:59 PST
https://hg.mozilla.org/mozilla-central/rev/ca5ebc597cdc
Comment 9 Timothy Nikkel (:tnikkel) 2011-12-30 12:47:05 PST
We usually prevent regions from getting arbitrary complex in situations like this by using something like SimplifyOutward. Fodder for a future bug I guess.

Note You need to log in before you can comment on or make changes to this bug.