Closed Bug 711887 Opened 13 years ago Closed 8 years ago

Add aborts for easily avoidable main thread i/o

Categories

(Core :: Networking: File, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: khuey, Assigned: khuey)

References

(Depends on 4 open bugs)

Details

(Keywords: main-thread-io, Whiteboard: [Snappy:P2][necko-backlog])

Attachments

(1 file)

Attached patch PatchSplinter Review
This starts as a warning, and after we fix the dependent bugs we can make it an assert and then an abort.
Attachment #582717 - Flags: review?(jduell.mcbugs)
Assignee: nobody → khuey
Comment on attachment 582717 [details] [diff] [review]
Patch

Review of attachment 582717 [details] [diff] [review]:
-----------------------------------------------------------------

The entire idea of DEFER_OPEN seems a little dodgy to me--seems so easy to forget that all the usual open() errors (missing/permission issues, etc) are likely to be forgotten.  Hopefully all the users are savvy.

That said this patch looks fine.
Attachment #582717 - Flags: review?(jduell.mcbugs) → review+
Kyle do you have any plans of landing this? Seems like this would be a good regression test to track via telemetry evolution.
Whiteboard: [Snappy] → [Snappy:P2]
Yeah I've just been busy.
land it or wontfix it please..
Flags: needinfo?(khuey)
Whiteboard: [Snappy:P2] → [Snappy:P2][necko-backlog]
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(khuey)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: