711932 - 500 error in dashboard for some users, also for some user pages

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Description

[Piotr Zalewa [:zalun]]

Recently (after fixing the bug 661617) quite a few dashboard pages raise the UndefinedError:

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/jetpack/templates/_package_browser_addon.html", line 12, in top-level template code
    version <span class="version-name">{{ item.latest.get_version_name()}}</span>

UndefinedError: 'None' has no attribute 'get_version_name'

These are some broken user dashboard pages plus following user pages:

* http://builder.addons.mozilla.org/user/5531660/
* http://builder.addons.mozilla.org/user/Patrick2000/

Comment 1

[Piotr Zalewa [:zalun]]

The idea is to add get_latest function which will fix if possible or else delete broken packages.

in review: https://github.com/mozilla/FlightDeck/pull/89

Comment 2

[Piotr Zalewa [:zalun]]

packages are not fixed if they have the same full_name:

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/person/templates/_dashboard_addon.html", line 8, in block "amo_info"
    data-get_addon_info_url="{{ item.get_latest().get_status_url() }}">

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/jetpack/models.py", line 1570, in get_latest
    self.save()

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/jetpack/models.py", line 1524, in save
    super(Package, self).save(**kwargs)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/base/models.py", line 16, in save
    self.full_clean()

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/db/models/base.py", line 828, in full_clean
    raise ValidationError(errors)

ValidationError: {'__all__': [u'Package with this Author and Name already exists.']}

Comment 3

[Piotr Zalewa [:zalun]]

fixing the duplicated name on add-on save (in review)
https://github.com/mozilla/FlightDeck/pull/96

Comment 4

[Piotr Zalewa [:zalun]]

There is a need to run ``./manage.py fix_packages`` on production (after deploying to production)

Comment 5

[Piotr Zalewa [:zalun]]

We weren't raising an error if save failed on validation
This is fixed now
https://github.com/mozilla/FlightDeck/pull/111

For some reason it raises for 'Package with this Author and Name already exists.', but this will prevent from returning an unsaved Package