712026 - Localize arcball/controller keys in Tilt

Status: RESOLVED WONTFIX

(DevTools :: Inspector, defect)

Description

[Victor Porof [:vporof][:vp]]

Currently, we're using WASD for rotations, up/down/left/right for translations, =/+/I and -/O for zooming (as defined in [0]).

It would be a good idea to make these localizable.

[0] http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.dtd#471

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

I'm not using browser.dtd for this because these keys aren't mapped to any real xul elements, and I only need to access them via js at the moment. Adding them to browser.dtd and creating buttons in js with these access keys and then taking them out again seems like over-engineering.

When this stuff will be incorporated in bug 713265, moving the keys in a dtd file would make sense.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 584172 [details] [diff] [review]
v1

This looks like it'd be really easy for a localizer to break the UI, we should code some sane defaults in case someone makes
tilt.controller.pan.right = VK_RECHTS
or so.

Also, how far out is the real UI?

Comment 3

[Dão Gottwald [:dao]]

(In reply to Axel Hecht [:Pike] from comment #2)
> This looks like it'd be really easy for a localizer to break the UI, we
> should code some sane defaults in case someone makes
> tilt.controller.pan.right = VK_RECHTS
> or so.

I don't see why this should be localized in the first place.

The other keys in this patch should probably just use actual characters, not key codes.

Comment 4

[Rob Campbell [:rc] (:robcee)]

I'm fine with leaving this unlocalizeable if that seems like a reasonable thing to do. I was concerned that some of the keys (e.g., zoom controls on I and O) might not make sense in some areas or that ASDW could be absent or in the wrong locations on some international keyboards.

WONTFIX if that is appropriate.

Comment 5

[Dão Gottwald [:dao]]

It doesn't need to be all or nothing.

Arrow keys make sense for all locales. (Or not... I hate that they're inverted, but this applies to all locales alike.)

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v2

(In reply to Rob Campbell [:rc] (robcee) from comment #4)
> I'm fine with leaving this unlocalizeable if that seems like a reasonable
> thing to do. I was concerned that some of the keys (e.g., zoom controls on I
> and O) might not make sense in some areas or that ASDW could be absent or in
> the wrong locations on some international keyboards.
> 
> WONTFIX if that is appropriate.

I don't really feel like this should be a WONTFIX. Anyway, I attached a patch with all the keys localized except the arrow keys.

Dão, what do you think?

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 588389 [details] [diff] [review]
v2

>+tilt.controller.rotate.up    = VK_W
>+tilt.controller.rotate.down  = VK_S
>+tilt.controller.rotate.left  = VK_A
>+tilt.controller.rotate.right = VK_D

VK_W should just be w in the properties file, VK_S should be s, etc.

>+tilt.controller.zoom.in2 = VK_ADD

>+tilt.controller.zoom.out2 = VK_SUBTRACT

>+tilt.controller.zoom.reset2 = VK_0

These don't need to be localized.

>+tilt.controller.zoom.in3 = VK_EQUALS

I'm not sure this needs to be localized. What's the rational for this key anyway?

Comment 8

[Axel Hecht [:Pike]]

equals is there so that you don't have to press shift-= to get to +.

Depending on keyboard layout, that might be a different key.

Luckily, I'm an ignorant on keyboard layouts, so I don't know more about what can actually happen, and if +-0 might be bad on some keyboard.

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Dão Gottwald [:dao] from comment #7)
> Comment on attachment 588389 [details] [diff] [review]
> v2

Well, we took out arrow keys. If we take out zoom keys, the only remaining thing needing to be localized is rotation keys. Do we need to do this for just 4 keys which don't have UI? :)

Comment 10

[Dão Gottwald [:dao]]

(In reply to Axel Hecht [:Pike] from comment #8)
> Luckily, I'm an ignorant on keyboard layouts, so I don't know more about
> what can actually happen, and if +-0 might be bad on some keyboard.

Hm, I thought the Ctrl+{+,-,0} browser zoom keys weren't localized, but they are. Are there any locales that changed them?

Comment 11

[Axel Hecht [:Pike]]

Hrm. none of them are. Neither the +-0 nor the =, nor are the alternative commandkey2s in use.

I'd link to mxr, but that failed on me, I ended up doing a few local greps.

Comment 12

[Victor Porof [:vporof][:vp]]

So, WONTFIX?

Comment 13

[Rob Campbell [:rc] (:robcee)]

yeah, sounds like. Sorry for the extra work. :/

Please reopen if this is wanted.

Comment 14

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 588389 [details] [diff] [review]
v2

clearing review request.

Comment 15

[Victor Porof [:vporof][:vp]]

Yay!