If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Investigate if patches could have priority flags

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
General
--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: smaug, Assigned: dkl)

Tracking

Production

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
It would be useful for me, as a reviewer (who reviews quite a lot), to know which
patches are higher priority than others. Usually patches are just patches, but in some 
cases the developer really wants to get the review soon.
This happens often near Aurora uplift.

Higher priority patches could be highlighted somehow in the request queue.
i'm not really sure what you're asking here -- bugs already have a priority field which you can use.

are you asking for the request queue to show/sort-by priority?
(Reporter)

Comment 2

6 years ago
yeah, true, bugs do have priority flags. Perhaps request queue could highlight PX bugs somehow.
I think that could work well enough.

Though, I was thinking about some flag where developer could basically beg
"please review this before next Aurora" :)
(Assignee)

Comment 3

6 years ago
Two things come to mind when I think about what you are asking. 

1. We use the current priority value in the bug reports to CSS highlight the request rows in request.cgi. We do this for buglist.cgi now so we could mimic that as well. (low amount of work and possibly upstream as well)

2. Add a new attribute to attachments themselves called priority that would be set for each attachment individually regardless of bug priority. (high amount of work and less likely to be accepted upstream) Could also be confusing since then you can have low priority bugs but high priority patches so how do you determine where to focus work efforts?

Which are you asking? I would lean towards #1 is possible and probably veto #2 in hopes to finding a better solution.

dkl
(Reporter)

Comment 4

6 years ago
I'm asking for #2, but I would be happy with #1 :)
(Assignee)

Comment 5

6 years ago
Created attachment 583618 [details] [diff] [review]
Patch to highlight rows based on severity,priority,status and resolution of the bug (v1)

Patch that adds buglist.cgi type styling to the rows displayed in request.cgi.

dkl
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attachment #583618 - Flags: review?(glob)
Comment on attachment 583618 [details] [diff] [review]
Patch to highlight rows based on severity,priority,status and resolution of the bug (v1)

i don't think just adding background shading is enough; it would be much clearer to also show the bug's priority and severity in the table (you could probably show both values in a single cell).

>+    <tr id="b[% request.bug_id %]" class="bz_bugitem

you don't need to set an id, and it's possible to have multiple requests from the same bug so you'd end up with duplicate ids.

>+            bz_[% request.bug_severity FILTER css_class_quote -%]
>+            bz_[% request.priority FILTER css_class_quote -%]
>+            bz_[% request.bug_status FILTER css_class_quote -%]

this looks good :)

>+            [%+ "bz_$request.resolution" FILTER css_class_quote IF request.resolution -%]

i don't think the resolution highlighting belongs here.
Attachment #583618 - Flags: review?(glob) → review-
(Assignee)

Comment 7

6 years ago
Created attachment 584472 [details] [diff] [review]
Patch to highlight rows based on severity,priority,status and resolution of the bug (v2)

Thanks Byron. Here is a new patch that addresses your suggested changes.

dkl
Attachment #583618 - Attachment is obsolete: true
Attachment #584472 - Flags: review?(glob)
Comment on attachment 584472 [details] [diff] [review]
Patch to highlight rows based on severity,priority,status and resolution of the bug (v2)

Review of attachment 584472 [details] [diff] [review]:
-----------------------------------------------------------------

excellent :)  r=glob
Attachment #584472 - Flags: review?(glob) → review+
(Assignee)

Comment 9

6 years ago
Thanks. Committed and should be in the next code push.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0
modified template/en/default/request/queue.html.tmpl
modified request.cgi
Committed revision 8015.

dkl
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.