Closed
Bug 712055
Opened 13 years ago
Closed 13 years ago
Remove xpc_qsInt32ToJsval/xpc_qsUint32ToJsval
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
3.22 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
They simply duplicate {U,}INT_TO_JSVAL
Attachment #582880 -
Flags: review?(bobbyholley+bmo)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 582880 [details] [diff] [review]
Patch v1
Seems reasonable, but best to check with the original author (jorendorff) to see why this was done. Flagging him for review.
Attachment #582880 -
Flags: review?(bobbyholley+bmo) → review?(jorendorff)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 582880 [details] [diff] [review]
Patch v1
I'm pretty sure that back when I wrote it, jsval couldn't handle a full 32 bits of int, and UINT_TO_JSVAL didn't exist.
Good patch. Thanks.
Attachment #582880 -
Flags: review?(jorendorff) → review+
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Summary: Remove xpc_qsInt32ToJsval/xpc_qsUint32ToJsva → Remove xpc_qsInt32ToJsval/xpc_qsUint32ToJsval
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•