Last Comment Bug 712055 - Remove xpc_qsInt32ToJsval/xpc_qsUint32ToJsval
: Remove xpc_qsInt32ToJsval/xpc_qsUint32ToJsval
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla12
Assigned To: :Ms2ger (⌚ UTC+1/+2)
: Andrew Overholt [:overholt]
Depends on:
  Show dependency treegraph
Reported: 2011-12-19 10:45 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-12-24 04:36 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (3.22 KB, patch)
2011-12-19 10:45 PST, :Ms2ger (⌚ UTC+1/+2)
jorendorff: review+
Details | Diff | Splinter Review

Description User image :Ms2ger (⌚ UTC+1/+2) 2011-12-19 10:45:34 PST
Created attachment 582880 [details] [diff] [review]
Patch v1

They simply duplicate {U,}INT_TO_JSVAL
Comment 1 User image Bobby Holley (:bholley) (busy with Stylo) 2011-12-19 12:06:17 PST
Comment on attachment 582880 [details] [diff] [review]
Patch v1

Seems reasonable, but best to check with the original author (jorendorff) to see why this was done. Flagging him for review.
Comment 2 User image Jason Orendorff [:jorendorff] 2011-12-21 15:00:32 PST
Comment on attachment 582880 [details] [diff] [review]
Patch v1

I'm pretty sure that back when I wrote it, jsval couldn't handle a full 32 bits of int, and UINT_TO_JSVAL didn't exist.

Good patch. Thanks.
Comment 3 User image :Ms2ger (⌚ UTC+1/+2) 2011-12-24 04:36:42 PST

Note You need to log in before you can comment on or make changes to this bug.