Remove xpc_qsInt32ToJsval/xpc_qsUint32ToJsval

RESOLVED FIXED in mozilla12

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 582880 [details] [diff] [review]
Patch v1

They simply duplicate {U,}INT_TO_JSVAL
Attachment #582880 - Flags: review?(bobbyholley+bmo)
Comment on attachment 582880 [details] [diff] [review]
Patch v1

Seems reasonable, but best to check with the original author (jorendorff) to see why this was done. Flagging him for review.
Attachment #582880 - Flags: review?(bobbyholley+bmo) → review?(jorendorff)
Comment on attachment 582880 [details] [diff] [review]
Patch v1

I'm pretty sure that back when I wrote it, jsval couldn't handle a full 32 bits of int, and UINT_TO_JSVAL didn't exist.

Good patch. Thanks.
Attachment #582880 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/25d4c80193c8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Summary: Remove xpc_qsInt32ToJsval/xpc_qsUint32ToJsva → Remove xpc_qsInt32ToJsval/xpc_qsUint32ToJsval
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.