Either brace should be clickable to add new properties in the Style panel's Rule View

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: grlicky, Assigned: rc)

Tracking

unspecified
Firefox 12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
It seems like one can only add properties by clicking on the line of the lower brace. It'd be a lot easier to be able to click on either one. Really, it would be great to be able to click on any whitespace in the style editor to add a style.

http://cl.ly/0N290t1C263g0w0p3b1D
(Assignee)

Updated

5 years ago
Component: Developer Tools: Style Editor → Developer Tools: Inspector
OS: Mac OS X → All
QA Contact: developer.tools.style.editor → developer.tools.inspector
Hardware: x86 → All
Summary: Either brace should be clickable to add new properties in the Style Editor → Either brace should be clickable to add new properties in the Style panel's Rule View
(Assignee)

Comment 1

5 years ago
Created attachment 583542 [details] [diff] [review]
open brace editor
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #583542 - Flags: review?(jwalker)

Comment 2

5 years ago
(In reply to Rob Campbell [:rc] (robcee) from comment #1)
> Created attachment 583542 [details] [diff] [review]
> open brace editor

I think you forgot to remove your code from bug 694954 :)
Comment on attachment 583542 [details] [diff] [review]
open brace editor

Review of attachment 583542 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/winstripe/devtools/csshtmltree.css
@@ +231,5 @@
>    padding: 2px 5px;
>  }
>  
> +.ruleview-ruleopen {
> +  padding-right: 5px;

padding-end: 5px; ?
Attachment #583542 - Flags: review?(jwalker) → review+
(Assignee)

Comment 4

5 years ago
paul: omg!

joe: oof!

double-smackdown. I feel suitably r-minused.
(Assignee)

Comment 5

5 years ago
Created attachment 583800 [details] [diff] [review]
open brace editor

updated patch
(Assignee)

Updated

5 years ago
Whiteboard: [land-in-fx-team]

Comment 6

5 years ago
(In reply to Rob Campbell [:rc] (robcee) from comment #5)
> Created attachment 583800 [details] [diff] [review]
> open brace editor
> 
> updated patch

Does padding-end exist?
I think you meant -moz-padding-end.

Updated

5 years ago
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/378207d85641

(updated stylesheets to use -moz-padding-end)
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/378207d85641
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
(Assignee)

Updated

5 years ago
Duplicate of this bug: 699213
You need to log in before you can comment on or make changes to this bug.