Closed Bug 712113 Opened 8 years ago Closed 8 years ago

Either brace should be clickable to add new properties in the Style panel's Rule View

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 12

People

(Reporter: grlicky, Assigned: rcampbell)

References

Details

Attachments

(2 files)

It seems like one can only add properties by clicking on the line of the lower brace. It'd be a lot easier to be able to click on either one. Really, it would be great to be able to click on any whitespace in the style editor to add a style.

http://cl.ly/0N290t1C263g0w0p3b1D
Component: Developer Tools: Style Editor → Developer Tools: Inspector
OS: Mac OS X → All
QA Contact: developer.tools.style.editor → developer.tools.inspector
Hardware: x86 → All
Summary: Either brace should be clickable to add new properties in the Style Editor → Either brace should be clickable to add new properties in the Style panel's Rule View
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #583542 - Flags: review?(jwalker)
(In reply to Rob Campbell [:rc] (robcee) from comment #1)
> Created attachment 583542 [details] [diff] [review]
> open brace editor

I think you forgot to remove your code from bug 694954 :)
Comment on attachment 583542 [details] [diff] [review]
open brace editor

Review of attachment 583542 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/winstripe/devtools/csshtmltree.css
@@ +231,5 @@
>    padding: 2px 5px;
>  }
>  
> +.ruleview-ruleopen {
> +  padding-right: 5px;

padding-end: 5px; ?
Attachment #583542 - Flags: review?(jwalker) → review+
paul: omg!

joe: oof!

double-smackdown. I feel suitably r-minused.
updated patch
Whiteboard: [land-in-fx-team]
(In reply to Rob Campbell [:rc] (robcee) from comment #5)
> Created attachment 583800 [details] [diff] [review]
> open brace editor
> 
> updated patch

Does padding-end exist?
I think you meant -moz-padding-end.
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/378207d85641

(updated stylesheets to use -moz-padding-end)
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/378207d85641
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
Duplicate of this bug: 699213
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.