571 bytes, patch
|Details | Diff | Splinter Review|
enter_bug.cgi should call Bugzilla::Product::preload similar to how it is called already in other places to allow preloading of attributes such as components, versions, milestones and flags. Flags particularly as create.html.tmpl calls component.flag_types for each component in product.components. This causes a call to Bugzilla::FlagType::match for every component. product.flag_types will preload all of it's components flag types, but product.flag_types is not called til later in the template. Calling Bugzilla::Product::preload in enter_bug.cgi will call product.flag_types before the template is loaded which will save each of the individual calls to Bugzilla::FlagType::match in component.flag_types. Patch coming. dkl
Created attachment 582943 [details] [diff] [review] Patch to add Bugzilal::Product::preload to enter_bug.cgi (v1)
Comment on attachment 582943 [details] [diff] [review] Patch to add Bugzilal::Product::preload to enter_bug.cgi (v1) Need to rework this as it has turned up an issue on BMO with version sorting on enter_bug.cgi. preload() causes the values to be sorted differently than if the accessors for each attribute were called separately. dkl
You need to log in before you can comment on or make changes to this bug.