/delayload gkmedia.dll

VERIFIED FIXED in Firefox 11

Status

()

Core
Build Config
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: (dormant account), Assigned: khuey)

Tracking

unspecified
mozilla12
x86
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox10 unaffected, firefox11+ verified, firefox12 verified)

Details

(Whiteboard: [qa!][testday-20120203])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
This should alleviate any startup regression caused by adding more files to read
I have a patch that compiles here, but since gkmedias.dll is in dependentlibs.list it gets loaded explicitly anyways.  Does gkmedias.dll really need to be in dependentlibs?
If I remove gkmedias.dll from dependentlibs.list I can start up the browser without loading it with my -DELAYLOAD patch.
Created attachment 585374 [details] [diff] [review]
Patch
Attachment #585374 - Flags: review?(mh+mozilla)
Nominating for tracking-firefox-11 because we'll want this to mitigate any startup time regression caused by the libxul crap during the 11 cycle.
tracking-firefox11: --- → ?

Comment 5

6 years ago
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #4)
> Nominating for tracking-firefox-11 because we'll want this to mitigate any
> startup time regression caused by the libxul crap during the 11 cycle.

Are there bugs tracking the libxul changes and startup time regressions?

This feels to me like a possible FF11 change if it's justified by measured startup regressions, but otherwise should probably just ride the train.
Attachment #585374 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/2c39af68ec8f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Component: General → Build Config
Flags: in-testsuite-
QA Contact: general → build-config
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
(Reporter)

Comment 7

6 years ago
Comment on attachment 585374 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): 709721
User impact if declined: slower startup than previous releases.
Testing completed (on m-c, etc.): it's landed on nightly
Risk to taking this patch (and alternatives if risky): /delayload should just work
Attachment #585374 - Flags: approval-mozilla-aurora?

Comment 8

6 years ago
Comment on attachment 585374 [details] [diff] [review]
Patch

[Triage Comment]
Low risk fix to a regression in FF11. Already landed on m-c without any reported issues.

Please provide QA a testing scenario where gkmedias.dll would be utilized so that they can ensure it's properly loaded.
Attachment #585374 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

6 years ago
tracking-firefox11: ? → +

Updated

6 years ago
Keywords: qawanted
The QA scenario here is simple:

1. Start the browser with a homepage like about:blank.

Verify that gkmedias.dll is not loaded (you can do this with Process Explorer).

2. Navigate to some site using html5 video (e.g. the Youtube webm trial).

Verify that gkmedias.dll is loaded and that the video works.
https://hg.mozilla.org/releases/mozilla-aurora/rev/e5999914bab4
status-firefox10: --- → unaffected
status-firefox11: --- → fixed
status-firefox12: --- → fixed
Whiteboard: [qa+]

Comment 11

5 years ago
Verified as fixed using the steps in comment 9 on:
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
status-firefox11: fixed → verified
Whiteboard: [qa+] → [qa+][qa:11!]

Updated

5 years ago
Whiteboard: [qa+][qa:11!] → [qa+][qa:11!][testday-20120203]
Removing qawanted since this has been verified fixed in Firefox 11.
Keywords: qawanted

Comment 13

5 years ago
Verified as fixed using the steps in comment 9 on:
Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20100101 Firefox/12.0
BuildID: 20120320212821
Status: RESOLVED → VERIFIED
status-firefox12: fixed → verified
Whiteboard: [qa+][qa:11!][testday-20120203] → [qa!][testday-20120203]
You need to log in before you can comment on or make changes to this bug.