712211 - Intermittent problem in test_0200_app_launch_apply_update.js (non service) test run

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

I saw this on elm. I'm not sure if it was an existing problem without the service or not but this patch should fix the problem.

1) test_gAppBinPath :: line 2457" [nsIFile.remove]
2) TypeError: gProcess is undefined


Full log:
TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/update/test/unit/head_update.js :: test_gAppBinPath :: line 2457"  data: no]
c:/talos-slave/test/build/xpcshell/tests/toolkit/mozapps/update/test/unit/test_0200_app_launch_apply_update.js:125: TypeError: gProcess is undefined
WARNING: nsExceptionService ignoring thread destruction after shutdown: file e:/builds/moz2_slave/elm-w32-dbg/build/xpcom/base/nsExceptionService.cpp, line 197

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch 0.5

This fixes the undefined problem when there is an exception or an early return, but it is not a good fix for the in use.  Because if the file is in use and can't be removed then the following copyTo will fail.

I don't know if the access denied error is due to permissions, the file being already started, or maybe read only. I'll investigate this more and post another patch before asking for review.

Comment 2

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/mozilla-central/rev/1dc69ce16ae3