712224 - Make jprof generate output that can be parsed by the 'cleopatra' front-end viewer

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

BenWa has a viewer for call-stack data called cleopatra - make jprof generate compatible output for that.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: working patch to generate cleopatra output

use '--cleo' to get the output; note that other options like --thread are still available, though not all make sense and some may produce odd results.  Note also that the symbols include args (important in that some names map to more than one function based on args)

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 583086 [details] [diff] [review]
working patch to generate cleopatra output

Requesting r (or rs) from dbaron - not part of the build so risk is zip, even if I fubarred the patch (and it seems to work fine).

FYI, you can drop data into the cleopatra front-end here:
http://varium.fantasytalesonline.com/cleopatra/

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 583086 [details] [diff] [review]
working patch to generate cleopatra output

rubber-stamp r=dbaron

I'm tempted to complain about following local style, but I can't tell what local style in this file is (e.g., "if(" vs. "if (" and whether the opening { after an if or else goes on the same line or its own line).

Comment 4

[Benoit Girard (:BenWa)]

Heads up we will change the URL in the future.

Also as we change the front end we will be adding additional features that may not make sense with the output produced from jprof (while I hope that most will just transparently benefits this output). 

It may make sense to add in tags so that you can disable feature in the visualization that don't make sense for jprof. Something like 'meta-Disable unknown' or something.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

(In reply to David Baron [:dbaron] from comment #3)
> I'm tempted to complain about following local style, but I can't tell what
> local style in this file is (e.g., "if(" vs. "if (" and whether the opening
> { after an if or else goes on the same line or its own line).

The style is already mildly mixed in leaky.cpp; all the new bits I added were "normal" style, but the part that's cut-and-pasted I didn't touch style on.  At some point I may assert style on the file, but I dislike doing that because it messes up history annotation.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0673da2a834a

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/0673da2a834a