Crash when fclose(NULL)'ing a battery-status FILE*

RESOLVED FIXED in mozilla12

Status

()

Core
Hardware Abstraction Layer (HAL)
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cjones, Assigned: cjones)

Tracking

Trunk
mozilla12
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

On the maguro device, we don't have the same /sys/class/power_supply/battery/charging_source file, so opening it fails.  Then we crash trying to close a null FILE*.  Simple fix, "real" fix to read the right file coming up later.
Created attachment 583089 [details] [diff] [review]
Don't try to fclose() NULL FILE*'s.

I'm happy to land this after the uplift.  Would prefer to not lose more blame history.
Assignee: nobody → jones.chris.g
Attachment #583089 - Flags: review?(mwu)

Updated

6 years ago
Attachment #583089 - Flags: review?(mwu) → review+

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa06927b6435
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/fa06927b6435
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.